Skip to content

dashboard: update version to v20231127.1#7458

Merged
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
mornyx:dashboard
Nov 28, 2023
Merged

dashboard: update version to v20231127.1#7458
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
mornyx:dashboard

Conversation

@mornyx
Copy link
Copy Markdown
Contributor

@mornyx mornyx commented Nov 28, 2023

What problem does this PR solve?

Issue Number: Close #7457

What is changed and how does it work?

Update tidb-dashboard to v20231127.1 to introduce component upgrades for security reason

Dashboard release PR: pingcap/tidb-dashboard#1620

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: mornyx <mornyx.z@gmail.com>
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Nov 28, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Nov 28, 2023
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Nov 28, 2023

Hi @mornyx. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from JmPotato and lhy1024 November 28, 2023 02:00
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 28, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 28, 2023

Codecov Report

Merging #7458 (0ef82b9) into master (82ace6f) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7458      +/-   ##
==========================================
- Coverage   74.21%   74.17%   -0.04%     
==========================================
  Files         451      451              
  Lines       49692    49692              
==========================================
- Hits        36879    36861      -18     
- Misses       9500     9516      +16     
- Partials     3313     3315       +2     
Flag Coverage Δ
unittests 74.17% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx
Copy link
Copy Markdown
Member

rleungx commented Nov 28, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Nov 28, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 28, 2023
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Nov 28, 2023

@xiabee: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 28, 2023
@rleungx
Copy link
Copy Markdown
Member

rleungx commented Nov 28, 2023

/merge

1 similar comment
@CabinfeverB
Copy link
Copy Markdown
Member

/merge

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Nov 28, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Nov 28, 2023

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Nov 28, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 0ef82b9

1 similar comment
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Nov 28, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 0ef82b9

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 28, 2023
@rleungx rleungx added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed status/can-merge Indicates a PR has been approved by a committer. labels Nov 28, 2023
@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 28, 2023
@ti-chi-bot ti-chi-bot bot merged commit f578a36 into tikv:master Nov 28, 2023
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #7460.

@mornyx mornyx deleted the dashboard branch November 28, 2023 02:32
rleungx pushed a commit to ti-chi-bot/pd that referenced this pull request Nov 28, 2023
close tikv#7457

Signed-off-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot bot pushed a commit that referenced this pull request Nov 28, 2023
close #7457

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Yexiang Zhang <mornyx.z@gmail.com>
@mornyx
Copy link
Copy Markdown
Contributor Author

mornyx commented Dec 11, 2023

/cherry-pick release-7.1

@ti-chi-bot
Copy link
Copy Markdown
Member

@mornyx: new pull request created to branch release-7.1: #7517.

Details

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Dec 11, 2023
close tikv#7457

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Copy Markdown
Member

@mornyx: cannot checkout 7.5: error checking out 7.5: exit status 1. output: error: pathspec '7.5' did not match any file(s) known to git

Details

In response to this:

/cherry-pick 7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@mornyx
Copy link
Copy Markdown
Contributor Author

mornyx commented Dec 11, 2023

/cherry-pick release-7.5

@ti-chi-bot
Copy link
Copy Markdown
Member

@mornyx: new pull request created to branch release-7.5: #7518.

Details

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update tidb-dashboard to introduce component upgrades for security reason

6 participants