Skip to content

placement-rule: move placement rule initialization after LoadStores#9616

Merged
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
okJiang:fix-placement-rule
Aug 4, 2025
Merged

placement-rule: move placement rule initialization after LoadStores#9616
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
okJiang:fix-placement-rule

Conversation

@okJiang
Copy link
Copy Markdown
Member

@okJiang okJiang commented Aug 1, 2025

…nce test coverage for store labels and leader transfer

What problem does this PR solve?

Issue Number: Close #9602

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test

Release note

Fix the bug that placement rule may disappear after PD transfer leader

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 1, 2025
…nce test coverage for store labels and leader transfer

Signed-off-by: okjiang <819421878@qq.com>
@okJiang okJiang force-pushed the fix-placement-rule branch from b755465 to e953427 Compare August 1, 2025 10:37
@okJiang
Copy link
Copy Markdown
Member Author

okJiang commented Aug 1, 2025

/retest

Signed-off-by: okjiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 1, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 1, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.61%. Comparing base (6c9e60f) to head (1173a60).
⚠️ Report is 279 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9616      +/-   ##
==========================================
- Coverage   76.61%   76.61%   -0.01%     
==========================================
  Files         483      483              
  Lines       75978    75980       +2     
==========================================
+ Hits        58214    58215       +1     
- Misses      14194    14196       +2     
+ Partials     3570     3569       -1     
Flag Coverage Δ
unittests 76.61% <40.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 4, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 4, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Aug 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [bufferflies,lhy1024]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 4, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Aug 4, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-04 06:59:51.967543977 +0000 UTC m=+251502.110305152: ☑️ agreed by bufferflies.
  • 2025-08-04 08:09:35.280421336 +0000 UTC m=+255685.423182511: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot bot merged commit 4d49880 into tikv:master Aug 4, 2025
24 of 26 checks passed
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Sep 17, 2025
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 17, 2025
close tikv#9602

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #9752.
But this PR has conflicts, please resolve them!

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Sep 17, 2025
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 17, 2025
close tikv#9602

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #9758.
But this PR has conflicts, please resolve them!

@okJiang okJiang deleted the fix-placement-rule branch September 18, 2025 04:00
ti-chi-bot bot pushed a commit that referenced this pull request Sep 19, 2025
…9616) (#9752)

close #9602

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: okjiang <819421878@qq.com>

Co-authored-by: okJiang <819421878@qq.com>
ti-chi-bot bot pushed a commit that referenced this pull request Sep 27, 2025
…9616) (#9758)

close #9602

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: okjiang <819421878@qq.com>

Co-authored-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. release-note-none Denotes a PR that doesn't merit a release note. labels Mar 24, 2026
ClamChowderTiDB added a commit to ClamChowderTiDB/pd that referenced this pull request Mar 26, 2026
…ikv#9616) (tikv#9752)

X-Original-Commit: dab6cfc413b9a315a56ab8fc12ec2dce6d14854b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

placement-rule may reset after leader-resign

4 participants