mcs: fix panic of store not found#9781
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
| // As TiKV report buckets just after the region heartbeat, for new created region, PD may receive buckets report before the first region heartbeat is handled. | ||
| // So we should not return error here. | ||
| log.Warn("the store of the bucket in region is not found ", zap.Uint64("region-id", buckets.GetRegionId())) | ||
| continue |
There was a problem hiding this comment.
The address can be nil if the store is nil
There was a problem hiding this comment.
Yes, it won't get the address if it is nil.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9781 +/- ##
==========================================
- Coverage 76.87% 76.77% -0.10%
==========================================
Files 488 488
Lines 77722 77727 +5
==========================================
- Hits 59751 59678 -73
- Misses 14337 14400 +63
- Partials 3634 3649 +15
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
/retest |
Signed-off-by: Ryan Leung <rleungx@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bufferflies, lhy1024 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
@rleungx: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
What problem does this PR solve?
Issue Number: ref #5839.
What is changed and how does it work?
Fix the following issue:
Check List
Tests
Release note