Skip to content

feat(metering): add DFS stats collector for write requests and bytes#9783

Merged
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
JmPotato:metering_dfs_stats
Sep 28, 2025
Merged

feat(metering): add DFS stats collector for write requests and bytes#9783
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
JmPotato:metering_dfs_stats

Conversation

@JmPotato
Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: ref #9707.

What is changed and how does it work?

Add `dfs-stats` collector to track DFS write requests and written bytes per keyspace/component.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato requested review from okJiang and rleungx September 26, 2025 03:24
@JmPotato JmPotato added the nextgen Indicates that the Issue or PR belongs to the nextgen kernel architecture. label Sep 26, 2025
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 26, 2025
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 26, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 80.83333% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.79%. Comparing base (9b18ac3) to head (f14d764).
⚠️ Report is 718 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9783      +/-   ##
==========================================
+ Coverage   73.71%   76.79%   +3.07%     
==========================================
  Files         440      490      +50     
  Lines       48866    78166   +29300     
==========================================
+ Hits        36024    60030   +24006     
- Misses       9769    14473    +4704     
- Partials     3073     3663     +590     
Flag Coverage Δ
unittests 76.79% <80.83%> (+3.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 28, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Sep 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 28, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Sep 28, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-28 02:19:09.832283782 +0000 UTC m=+755159.902777462: ☑️ agreed by rleungx.
  • 2025-09-28 03:50:44.93680142 +0000 UTC m=+760655.007295102: ☑️ agreed by okJiang.

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Sep 28, 2025

@JmPotato: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
non-block/pull-unit-test-next-gen f14d764 link false /test pull-unit-test-next-gen

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit f8ab6e5 into tikv:master Sep 28, 2025
28 of 29 checks passed
@JmPotato JmPotato deleted the metering_dfs_stats branch September 28, 2025 06:11
@JmPotato JmPotato restored the metering_dfs_stats branch September 30, 2025 01:08
@JmPotato JmPotato deleted the metering_dfs_stats branch September 30, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm nextgen Indicates that the Issue or PR belongs to the nextgen kernel architecture. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants