Skip to content

client/limiter: rename some variables for clarity#9791

Merged
ti-chi-bot[bot] merged 4 commits intotikv:masterfrom
okJiang:read-code-home
Oct 9, 2025
Merged

client/limiter: rename some variables for clarity#9791
ti-chi-bot[bot] merged 4 commits intotikv:masterfrom
okJiang:read-code-home

Conversation

@okJiang
Copy link
Copy Markdown
Member

@okJiang okJiang commented Sep 29, 2025

What problem does this PR solve?

Issue Number: Ref #4399

What is changed and how does it work?

- Rename `Limit` to `fillRate`, it is unified
- Rename `OK` to `Reserved`
- Rename `advance` to `getTokens`

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

…and efficiency

Signed-off-by: okjiang <819421878@qq.com>
…ation logic

Signed-off-by: okjiang <819421878@qq.com>
…arity

Signed-off-by: okjiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 29, 2025
@okJiang
Copy link
Copy Markdown
Member Author

okJiang commented Sep 29, 2025

/retest

1 similar comment
@okJiang
Copy link
Copy Markdown
Member Author

okJiang commented Sep 30, 2025

/retest

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 88.46154% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.83%. Comparing base (f8ab6e5) to head (9a1ceec).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9791      +/-   ##
==========================================
+ Coverage   76.75%   76.83%   +0.08%     
==========================================
  Files         490      491       +1     
  Lines       78166    78484     +318     
==========================================
+ Hits        59994    60307     +313     
- Misses      14499    14507       +8     
+ Partials     3673     3670       -3     
Flag Coverage Δ
unittests 76.83% <88.46%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 30, 2025
…llRate and reservation logic

Signed-off-by: okjiang <819421878@qq.com>
@okJiang
Copy link
Copy Markdown
Member Author

okJiang commented Sep 30, 2025

/retest

@okJiang
Copy link
Copy Markdown
Member Author

okJiang commented Sep 30, 2025

/cc @rleungx @bufferflies

@ti-chi-bot ti-chi-bot bot requested review from bufferflies and rleungx September 30, 2025 08:09
@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 9, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Oct 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 9, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Oct 9, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-30 05:43:36.346013071 +0000 UTC m=+149796.602744461: ☑️ agreed by JmPotato.
  • 2025-10-09 03:06:16.36661365 +0000 UTC m=+323165.397712978: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot bot merged commit 471d023 into tikv:master Oct 9, 2025
29 checks passed
@okJiang okJiang deleted the read-code-home branch October 9, 2025 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants