Skip to content

mcs: fix /config and /members tso forward logic#9796

Merged
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
lhy1024:fix-forward3
Oct 9, 2025
Merged

mcs: fix /config and /members tso forward logic#9796
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
lhy1024:fix-forward3

Conversation

@lhy1024
Copy link
Copy Markdown
Contributor

@lhy1024 lhy1024 commented Oct 3, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #9797

What is changed and how does it work?

We should not use a ServiceRedirector for all urls.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Before:
    img_v3_02qn_0f440e76-095e-4a6b-8fe6-de20ffdb3bdg
    After:
    img_v3_02qn_ac6545c0-4b1b-43f0-a347-ea8d279ddafg
    img_v3_02qn_f3aca22d-aff2-4101-ad57-a9da36dd1f7g
    img_v3_02qn_6a542d9e-b4d2-497d-88a6-7cf27eed946g

Release note

None.

@lhy1024
mcs: fix /config and /members tso forward logic
3237520 
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Oct 3, 2025
@lhy1024
fix lint
497cdcf 
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 9, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Oct 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [bufferflies,rleungx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 9, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Oct 9, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-10-09 03:24:58.053521906 +0000 UTC m=+324287.084621235: ☑️ agreed by bufferflies.
  • 2025-10-09 03:46:47.8254798 +0000 UTC m=+325596.856579128: ☑️ agreed by rleungx.

@rleungx
Copy link
Copy Markdown
Member

rleungx commented Oct 9, 2025

/retest

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 9, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.82%. Comparing base (a89e236) to head (497cdcf).
⚠️ Report is 20 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9796      +/-   ##
==========================================
- Coverage   76.84%   76.82%   -0.03%     
==========================================
  Files         484      491       +7     
  Lines       77250    78481    +1231     
==========================================
+ Hits        59366    60293     +927     
- Misses      14282    14516     +234     
- Partials     3602     3672      +70
Flag Coverage Δ
unittests 76.82% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot merged commit f59aebd into tikv:master Oct 9, 2025
47 of 51 checks passed
@nolouch nolouch added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Oct 9, 2025
@nolouch
Copy link
Copy Markdown
Contributor

nolouch commented Oct 9, 2025

/run-cherry-picker

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Oct 9, 2025
@lhy1024 @ti-chi-bot
This is an automated cherry-pick of tikv#9796
5d34ba3 
close tikv#9797

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Oct 9, 2025

In response to a cherrypick label: new pull request created to branch release-8.5: #9804.
But this PR has conflicts, please resolve them!

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Oct 9, 2025

In response to a cherrypick label: new pull request created to branch release-8.1: #9805.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Oct 9, 2025
@lhy1024 @ti-chi-bot
This is an automated cherry-pick of tikv#9796
deda385 
close tikv#9797

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Oct 9, 2025
Merged
Open
ti-chi-bot bot pushed a commit that referenced this pull request Oct 11, 2025
@ti-chi-bot @lhy1024
mcs: fix /config and /members tso forward logic (#9796) (#9804)
0557634 
close #9797

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: lhy1024 <liuhanyang@pingcap.com>
Co-authored-by: lhy1024 <admin@liudos.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bufferflies bufferflies bufferflies approved these changes

@rleungx rleungx rleungx approved these changes

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

mcs, tso: TSO API returns identical member info for different nodes

5 participants

@lhy1024 @rleungx @nolouch @ti-chi-bot @bufferflies
⚡