tests: fix TestPreparingProgress#9817
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot
bot
added
release-note-none
|
@rleungx: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9817 +/- ##
==========================================
- Coverage 76.92% 76.86% -0.07%
==========================================
Files 491 491
Lines 78311 78311
==========================================
- Hits 60240 60190 -50
- Misses 14393 14432 +39
- Partials 3678 3689 +11
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
rleungx
changed the title
TestPreparingProgressTestPreparingProgress
| re.NotEmpty(cluster.WaitLeader()) | ||
| leader = cluster.GetLeaderServer() |
There was a problem hiding this comment.
Is it necessary? We have checked the leader in L1144-1148
There was a problem hiding this comment.
The leader may be dropped due to the environmental issue.
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
close tikv#9607 Signed-off-by: Ryan Leung <rleungx@gmail.com>
3 participants
What problem does this PR solve?
Issue Number: Close #9607.
What is changed and how does it work?
Check List
Tests
Release note