Skip to content

mcs: fix /admin/log forward logic and add /config in resource manager#9826

Merged
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
lhy1024:fix-forward5
Dec 1, 2025
Merged

mcs: fix /admin/log forward logic and add /config in resource manager#9826
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
lhy1024:fix-forward5

Conversation

@lhy1024
Copy link
Copy Markdown
Contributor

@lhy1024 lhy1024 commented Oct 14, 2025

What problem does this PR solve?

Issue Number: Close #9825

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 14, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 14, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.55%. Comparing base (9f8f977) to head (c8a97e0).
⚠️ Report is 55 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9826      +/-   ##
==========================================
+ Coverage   76.91%   78.55%   +1.63%     
==========================================
  Files         491      503      +12     
  Lines       78440    67183   -11257     
==========================================
- Hits        60331    52774    -7557     
+ Misses      14425    10592    -3833     
- Partials     3684     3817     +133
Flag Coverage Δ
unittests 78.55% <100.00%> (+1.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 11, 2025
okJiang
okJiang reviewed Nov 28, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@okJiang okJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

tests/resource_manager_cluster.go Outdated
// See the License for the specific language governing permissions and
// limitations under the License.

// in tests/resource_manager_cluster.go
Copy link
Copy Markdown
Member

@okJiang okJiang Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this?

@lhy1024
fix lint
c8a97e0 
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 28, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Nov 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 28, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Nov 28, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-11-11 06:16:53.789557538 +0000 UTC m=+769263.232587407: ☑️ agreed by rleungx.
  • 2025-11-28 09:55:13.179777325 +0000 UTC m=+869476.828971782: ☑️ agreed by okJiang.

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Nov 28, 2025 •
edited
Loading

@lhy1024: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
non-block/pull-unit-test-next-gen e8692bd link false /test pull-unit-test-next-gen

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@okJiang
Copy link
Copy Markdown
Member

okJiang commented Dec 1, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit b83517a into tikv:master Dec 1, 2025
38 of 40 checks passed
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 3, 2025
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Dec 3, 2025
@lhy1024 @ti-chi-bot
This is an automated cherry-pick of tikv#9826
4fbd3a8 
close tikv#9825

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Dec 3, 2025

In response to a cherrypick label: new pull request created to branch release-8.5: #9989.
But this PR has conflicts, please resolve them!

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 3, 2025
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Dec 5, 2025
@ti-chi-bot @lhy1024
mcs: fix /admin/log forward logic and add /config in resource manager (…
c5b1422 
…#9826) (#9989)

close #9825

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: lhy1024 <liuhanyang@pingcap.com>
Co-authored-by: lhy1024 <admin@liudos.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rleungx rleungx rleungx approved these changes

+1 more reviewer

@okJiang okJiang okJiang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

There are also forward problems in scheduling, resource manager and pd

4 participants

@lhy1024 @okJiang @ti-chi-bot @rleungx
⚡