Skip to content

Unsafe Recovery: Add tombstoned tiflash learners into DemoteFailedVoters (#9554)#9830

Merged
ti-chi-bot[bot] merged 4 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-9554-to-release-8.5
Dec 3, 2025
Merged

Unsafe Recovery: Add tombstoned tiflash learners into DemoteFailedVoters (#9554)#9830
ti-chi-bot[bot] merged 4 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-9554-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

This is an automated cherry-pick of #9554

What problem does this PR solve?

Issue Number: Close #9624

What is changed and how does it work?

Remove tombtstoned TiFlash learners in DemoteFailedVoters phase

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

…ers (tikv#9554)

close tikv#9624

Remove tombtstoned TiFlash learners in DemoteFailedVoters phase

Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Oct 14, 2025
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 1, 2025
@v01dstar
Copy link
Copy Markdown
Member

v01dstar commented Dec 2, 2025

/retest

@v01dstar
Copy link
Copy Markdown
Member

v01dstar commented Dec 2, 2025

/test all

@v01dstar
Copy link
Copy Markdown
Member

v01dstar commented Dec 2, 2025

/retest-required

Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
@v01dstar v01dstar force-pushed the cherry-pick-9554-to-release-8.5 branch from 8883a18 to 9908efc Compare December 2, 2025 21:31
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.67%. Comparing base (0557634) to head (893b755).
⚠️ Report is 5 commits behind head on release-8.5.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-8.5    #9830      +/-   ##
===============================================
+ Coverage        75.87%   77.67%   +1.80%     
===============================================
  Files              467      467              
  Lines            73920    62369   -11551     
===============================================
- Hits             56088    48448    -7640     
+ Misses           14272    10347    -3925     
- Partials          3560     3574      +14     
Flag Coverage Δ
unittests 77.67% <100.00%> (+1.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 2, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 3, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 3, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Dec 3, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-02 22:59:56.633732544 +0000 UTC m=+390741.447510106: ☑️ agreed by nolouch.
  • 2025-12-03 06:24:33.811263609 +0000 UTC m=+417418.625041171: ☑️ agreed by JmPotato.

@ti-chi-bot ti-chi-bot bot merged commit c9152c8 into tikv:release-8.5 Dec 3, 2025
23 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-9554-to-release-8.5 branch December 3, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants