Skip to content

tests: fix TestKeyspaceServiceLimitAPI#9839

Merged
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
rleungx:fix-test-26h1-16
Oct 15, 2025
Merged

tests: fix TestKeyspaceServiceLimitAPI#9839
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
rleungx:fix-test-26h1-16

Conversation

@rleungx
Copy link
Copy Markdown
Member

@rleungx rleungx commented Oct 15, 2025

What problem does this PR solve?

Issue Number: Close #9838.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Oct 15, 2025
@rleungx rleungx requested review from JmPotato and lhy1024 October 15, 2025 10:00
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 15, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Oct 15, 2025

@rleungx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
non-block/pull-unit-test-next-gen 69c9daa link false /test pull-unit-test-next-gen

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 15, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 15, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Oct 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 15, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Oct 15, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-10-15 10:10:52.940216256 +0000 UTC m=+261759.017468816: ☑️ agreed by lhy1024.
  • 2025-10-15 10:17:22.135638349 +0000 UTC m=+262148.212890899: ☑️ agreed by JmPotato.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.86%. Comparing base (33d00c5) to head (69c9daa).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9839      +/-   ##
==========================================
+ Coverage   76.82%   76.86%   +0.04%     
==========================================
  Files         491      491              
  Lines       78440    78463      +23     
==========================================
+ Hits        60261    60311      +50     
+ Misses      14478    14454      -24     
+ Partials     3701     3698       -3     
Flag Coverage Δ
unittests 76.86% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot merged commit 2d6a14a into tikv:master Oct 15, 2025
37 of 41 checks passed
@rleungx rleungx deleted the fix-test-26h1-16 branch October 16, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Data race in TestKeyspaceServiceLimitAPI

3 participants