feat(router service): support to sync region from pd leader by bufferflies · Pull Request #9845 · tikv/pd

bufferflies · 2025-10-17T01:57:10Z

What problem does this PR solve?

Issue Number: ref #9212

What is changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has the configuration change
Has HTTP API interfaces changed (Don't forget to add the declarative for the new API)
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
PR to update pingcap/tiup:
Need to cherry-pick to the release branch

Release note

None.

Signed-off-by: 童剑 <1045931706@qq.com>

ti-chi-bot · 2025-10-17T01:57:13Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: 童剑 <1045931706@qq.com>

codecov · 2025-10-20T10:13:08Z

Codecov Report

❌ Patch coverage is 78.92857% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.52%. Comparing base (d9219d5) to head (c7d1838).
⚠️ Report is 23 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #9845      +/-   ##
==========================================
- Coverage   78.70%   78.52%   -0.18%     
==========================================
  Files         492      503      +11     
  Lines       66268    67131     +863     
==========================================
+ Hits        52153    52717     +564     
- Misses      10408    10592     +184     
- Partials     3707     3822     +115

Flag	Coverage Δ
unittests	`78.52% <78.92%> (-0.18%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: 童剑 <1045931706@qq.com>

pkg/mcs/router/server/sync.go

pkg/syncer/server.go

pkg/mcs/router/server/sync.go

rleungx · 2025-11-13T03:09:55Z

pkg/syncer/server.go

@@ -138,6 +138,7 @@ func (s *RegionSyncer) RunServer(ctx context.Context, regionNotifier <-chan *cor
 		select {
 		case <-ctx.Done():
 			log.Info("region syncer has been stopped")
+			s.closeAllClient()


Is it a leak?

no， the follower will recampaign and close the client stream also in most cases.

pkg/mcs/router/server/sync.go

rleungx · 2025-11-13T03:14:09Z

pkg/mcs/router/server/sync.go

+		}
+		log.Info("server starts to synchronize with leader", zap.String("server", s.name), zap.String("leader", leaderAddr), zap.Uint64("request-index", s.nextSyncIndex))
+		for {
+			resp, err := stream.Recv()


Do we need to check the io.EOF?

yes, I think we should handle this error

okJiang

rest lgtm

pkg/mcs/router/server/sync.go

rleungx · 2025-11-13T08:44:50Z

pkg/mcs/router/server/server.go

 	s.CloseClientConns()
-	s.serverLoopCancel()
+	if s.serverLoopCancel != nil {


Seem it cannot be nil

pkg/mcs/router/server/sync.go

Signed-off-by: 童剑 <1045931706@qq.com>

ti-chi-bot · 2025-11-25T08:50:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [rleungx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2025-11-25T08:50:55Z

[LGTM Timeline notifier]

Timeline:

2025-11-24 10:18:12.861297359 +0000 UTC m=+525256.510491815: ☑️ agreed by rleungx.
2025-11-25 08:50:53.898028454 +0000 UTC m=+606417.547222911: ☑️ agreed by okJiang.

rleungx · 2025-11-25T09:29:55Z

CI failed

Signed-off-by: 童剑 <1045931706@qq.com>

bufferflies · 2025-11-25T13:22:59Z

/test pull-unit-test-next-gen

bufferflies · 2025-11-25T13:40:32Z

/test pull-unit-test-next-gen

bufferflies · 2025-11-25T14:14:55Z

/retest

bufferflies · 2025-11-26T01:52:48Z

/retest

rleungx · 2025-11-26T02:43:44Z

/test pull-unit-test-next-gen

sync

ce44976

Signed-off-by: 童剑 <1045931706@qq.com>

add test

b1ab218

Signed-off-by: 童剑 <1045931706@qq.com>

bufferflies force-pushed the sync branch from 3bb2753 to 0f6218e Compare October 20, 2025 10:05

add more test

69038d4

Signed-off-by: 童剑 <1045931706@qq.com>

bufferflies force-pushed the sync branch 2 times, most recently from 23817f0 to c737484 Compare October 23, 2025 04:00

bufferflies marked this pull request as ready for review October 23, 2025 04:34

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2025

bufferflies changed the title ~~feat(router service): support to sync region from pd leader~~ [WIP]feat(router service): support to sync region from pd leader Oct 23, 2025

ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2025

bufferflies force-pushed the sync branch 2 times, most recently from cefb214 to 8e04378 Compare October 23, 2025 07:50

remove sleep

5341670

Signed-off-by: 童剑 <1045931706@qq.com>

bufferflies force-pushed the sync branch from 8e04378 to 5341670 Compare October 24, 2025 02:09

bufferflies changed the title ~~[WIP]feat(router service): support to sync region from pd leader~~ feat(router service): support to sync region from pd leader Nov 4, 2025

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2025

Merge branch 'master' of github.com:tikv/pd into sync

c82ffb6

ti-chi-bot bot removed the do-not-merge/needs-linked-issue label Nov 5, 2025

okJiang reviewed Nov 10, 2025

View reviewed changes

bufferflies requested a review from rleungx November 12, 2025 02:53

bufferflies force-pushed the sync branch from 1953e10 to e87488b Compare November 12, 2025 12:52

rleungx reviewed Nov 13, 2025

View reviewed changes

pkg/mcs/router/server/sync.go Show resolved Hide resolved

rleungx reviewed Nov 13, 2025

View reviewed changes

okJiang reviewed Nov 13, 2025

View reviewed changes

pkg/mcs/router/server/sync.go Outdated Show resolved Hide resolved

bufferflies force-pushed the sync branch from e87488b to 7666627 Compare November 13, 2025 07:46

rleungx reviewed Nov 13, 2025

View reviewed changes

address commit

f24d818

Signed-off-by: 童剑 <1045931706@qq.com>

bufferflies force-pushed the sync branch from 7666627 to f24d818 Compare November 20, 2025 11:53

bufferflies requested a review from rleungx November 24, 2025 05:08

rleungx approved these changes Nov 24, 2025

View reviewed changes

ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 24, 2025

okJiang approved these changes Nov 25, 2025

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 25, 2025

bufferflies force-pushed the sync branch from dba5407 to e01ff3d Compare November 25, 2025 12:42

context

c7d1838

Signed-off-by: 童剑 <1045931706@qq.com>

bufferflies force-pushed the sync branch from e01ff3d to c7d1838 Compare November 25, 2025 12:47

ti-chi-bot bot merged commit e2e6ca1 into tikv:master Nov 26, 2025
38 of 40 checks passed

Conversation

bufferflies commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

Uh oh!

ti-chi-bot bot commented Oct 17, 2025

Uh oh!

codecov bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rleungx Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

bufferflies Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rleungx Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

bufferflies Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

okJiang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rleungx Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ti-chi-bot bot commented Nov 25, 2025

Uh oh!

ti-chi-bot bot commented Nov 25, 2025

[LGTM Timeline notifier]

Uh oh!

rleungx commented Nov 25, 2025

Uh oh!

bufferflies commented Nov 25, 2025

Uh oh!

bufferflies commented Nov 25, 2025

Uh oh!

bufferflies commented Nov 25, 2025

Uh oh!

bufferflies commented Nov 26, 2025

Uh oh!

rleungx commented Nov 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bufferflies commented Oct 17, 2025 •

edited

Loading

codecov bot commented Oct 20, 2025 •

edited

Loading