Skip to content

*: fix linter on mac#9863

Merged
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
rleungx:fix-linter
Oct 30, 2025
Merged

*: fix linter on mac#9863
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
rleungx:fix-linter

Conversation

@rleungx
Copy link
Copy Markdown
Member

@rleungx rleungx commented Oct 22, 2025

What problem does this PR solve?

Issue Number: Close #9856.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 22, 2025
@rleungx
Copy link
Copy Markdown
Member Author

rleungx commented Oct 22, 2025

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 22, 2025
@rleungx
fix linter
50814bb 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
Copy link
Copy Markdown
Member Author

rleungx commented Oct 22, 2025

/retest

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 22, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.81%. Comparing base (14ac685) to head (50814bb).
⚠️ Report is 14 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9863      +/-   ##
==========================================
- Coverage   76.87%   76.81%   -0.06%     
==========================================
  Files         491      491              
  Lines       78475    78583     +108     
==========================================
+ Hits        60324    60365      +41     
- Misses      14457    14510      +53     
- Partials     3694     3708      +14
Flag Coverage Δ
unittests 76.81% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rleungx
Copy link
Copy Markdown
Member Author

rleungx commented Oct 22, 2025

/test pull-unit-test-next-gen

2 similar comments
@rleungx
Copy link
Copy Markdown
Member Author

rleungx commented Oct 22, 2025

/test pull-unit-test-next-gen

@rleungx
Copy link
Copy Markdown
Member Author

rleungx commented Oct 22, 2025

/test pull-unit-test-next-gen

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 23, 2025
@rleungx
Copy link
Copy Markdown
Member Author

rleungx commented Oct 23, 2025

/test pull-unit-test-next-gen

1 similar comment
@rleungx
Copy link
Copy Markdown
Member Author

rleungx commented Oct 23, 2025

/test pull-unit-test-next-gen

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Oct 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 23, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Oct 23, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-10-23 00:11:53.914251332 +0000 UTC m=+917019.991503892: ☑️ agreed by bufferflies.
  • 2025-10-23 03:30:05.030937489 +0000 UTC m=+928911.108190059: ☑️ agreed by okJiang.

@rleungx
Copy link
Copy Markdown
Member Author

rleungx commented Oct 23, 2025

/test pull-unit-test-next-gen

1 similar comment
@rleungx
Copy link
Copy Markdown
Member Author

rleungx commented Oct 23, 2025

/test pull-unit-test-next-gen

@rleungx
Copy link
Copy Markdown
Member Author

rleungx commented Oct 23, 2025

/test pull-unit-test-next-gen

2 similar comments
@rleungx
Copy link
Copy Markdown
Member Author

rleungx commented Oct 29, 2025

/test pull-unit-test-next-gen

@rleungx
Copy link
Copy Markdown
Member Author

rleungx commented Oct 30, 2025

/test pull-unit-test-next-gen

@ti-chi-bot ti-chi-bot bot merged commit 22e4832 into tikv:master Oct 30, 2025
38 of 40 checks passed
@rleungx rleungx deleted the fix-linter branch October 30, 2025 07:37
JmPotato pushed a commit to ti-chi-bot/pd that referenced this pull request Feb 6, 2026
@rleungx @JmPotato
*: fix linter on mac (tikv#9863)
f8f4924 
close tikv#9856

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bufferflies bufferflies bufferflies approved these changes

@lhy1024 lhy1024 Awaiting requested review from lhy1024

+1 more reviewer

@okJiang okJiang okJiang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

make check failed on Mac

3 participants

@rleungx @bufferflies @okJiang
⚡