keyspace: wait region split for system keyspace in next gen by lhy1024 · Pull Request #9880 · tikv/pd

lhy1024 · 2025-10-28T04:15:45Z

What problem does this PR solve?

Issue Number: Close #9879

What is changed and how does it work?

Check List

Tests

Unit test

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>

bufferflies · 2025-10-28T05:06:17Z

pkg/keyspace/keyspace.go

+	if id == constant.SystemKeyspaceID {
+		waitRegionSplit = true
+	}
+	if err := manager.splitKeyspaceRegion(id, waitRegionSplit); err != nil {


How about just splitKeyspaceRegion(id, id == constant.SystemKeyspaceID)

Signed-off-by: lhy1024 <admin@liudos.us>

ti-chi-bot · 2025-10-28T05:39:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [bufferflies,rleungx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2025-10-28T05:39:36Z

[LGTM Timeline notifier]

Timeline:

2025-10-28 04:22:08.048471738 +0000 UTC m=+1364034.125724288: ☑️ agreed by rleungx.
2025-10-28 05:39:35.530709857 +0000 UTC m=+1368681.607962407: ☑️ agreed by bufferflies.

lhy1024 · 2025-10-28T05:57:16Z

/test pull-unit-test-next-gen

lhy1024 · 2025-10-28T06:02:57Z

/test pull-unit-test-next-gen

lhy1024 · 2025-10-28T06:40:19Z

/test pull-unit-test-next-gen

lhy1024 · 2025-10-28T06:46:34Z

/test pull-unit-test-next-gen

codecov · 2025-10-28T06:58:10Z

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.66%. Comparing base (9339b48) to head (7e330f3).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #9880      +/-   ##
==========================================
+ Coverage   78.64%   78.66%   +0.02%     
==========================================
  Files         491      491              
  Lines       66217    66239      +22     
==========================================
+ Hits        52074    52109      +35     
+ Misses      10435    10420      -15     
- Partials     3708     3710       +2

Flag	Coverage Δ
unittests	`78.66% <50.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

rleungx · 2025-10-28T07:02:23Z

/test pull-unit-test-next-gen

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 · 2025-10-28T08:26:19Z

/test pull-unit-test-next-gen

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 · 2025-10-28T09:02:56Z

/test pull-unit-test-next-gen

lhy1024 · 2025-10-28T09:11:23Z

/test pull-unit-test-next-gen

lhy1024 · 2025-10-28T09:29:55Z

/test pull-unit-test-next-gen

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 · 2025-10-28T11:31:09Z

/test pull-unit-test-next-gen

lhy1024 · 2025-10-28T11:42:50Z

/test pull-unit-test-next-gen

lhy1024 · 2025-10-28T12:01:11Z

/test pull-unit-test-next-gen

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 · 2025-10-28T13:02:29Z

/test pull-unit-test-next-gen

lhy1024 · 2025-10-28T13:32:25Z

/cherry-pick release-nextgen-20251011

ti-chi-bot · 2025-10-28T13:33:04Z

@lhy1024: new pull request created to branch release-nextgen-20251011: #9884.

Details

In response to this:

/cherry-pick release-nextgen-20251011

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

…9884) close #9879 Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: lhy1024 <admin@liudos.us>

…ikv#9880)" This reverts commit e4a899a. Signed-off-by: lhy1024 <admin@liudos.us>

…9880)" (#9885) close #9879 Signed-off-by: lhy1024 <admin@liudos.us>

…ikv#9880)" This reverts commit e4a899a. Signed-off-by: lhy1024 <admin@liudos.us>

…9880)" (#9885) (#9886) close #9879 Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: lhy1024 <admin@liudos.us>

keyspace: wait region split for system keyspace in next gen

d98e9d9

Signed-off-by: lhy1024 <admin@liudos.us>

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 28, 2025

rleungx approved these changes Oct 28, 2025

View reviewed changes

ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 28, 2025

bufferflies reviewed Oct 28, 2025

View reviewed changes

address comments

c66e2a6

Signed-off-by: lhy1024 <admin@liudos.us>

bufferflies approved these changes Oct 28, 2025

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 28, 2025

ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 28, 2025

make test stable

8c4c79b

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 force-pushed the keyspace14 branch from 540460c to 8c4c79b Compare October 28, 2025 07:11

use config

c10ebe1

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 force-pushed the keyspace14 branch from acc0108 to c10ebe1 Compare October 28, 2025 08:09

fix test

cd788a9

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 added 2 commits October 28, 2025 18:47

fix test

aa09a55

Signed-off-by: lhy1024 <admin@liudos.us>

fix test again

ac2ce9b

Signed-off-by: lhy1024 <admin@liudos.us>

disable Keyspace.WaitRegionSplit in test

7e330f3

Signed-off-by: lhy1024 <admin@liudos.us>

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 28, 2025

ti-chi-bot bot merged commit e4a899a into tikv:master Oct 28, 2025
27 of 29 checks passed

lhy1024 deleted the keyspace14 branch October 28, 2025 13:32

ti-chi-bot mentioned this pull request Oct 28, 2025

keyspace: wait region split for system keyspace in next gen (#9880) #9884

Merged

ti-chi-bot bot pushed a commit that referenced this pull request Oct 28, 2025

keyspace: wait region split for system keyspace in next gen (#9880) (#…

f4f455e

…9884) close #9879 Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: lhy1024 <admin@liudos.us>

lhy1024 added a commit to lhy1024/pd that referenced this pull request Oct 29, 2025

Revert "keyspace: wait region split for system keyspace in next gen (t…

7511861

…ikv#9880)" This reverts commit e4a899a. Signed-off-by: lhy1024 <admin@liudos.us>

ti-chi-bot bot pushed a commit that referenced this pull request Oct 29, 2025

Revert "keyspace: wait region split for system keyspace in next gen (#…

5bdd248

…9880)" (#9885) close #9879 Signed-off-by: lhy1024 <admin@liudos.us>

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Oct 29, 2025

Revert "keyspace: wait region split for system keyspace in next gen (t…

43591b3

…ikv#9880)" This reverts commit e4a899a. Signed-off-by: lhy1024 <admin@liudos.us>

ti-chi-bot bot pushed a commit that referenced this pull request Oct 29, 2025

Revert "keyspace: wait region split for system keyspace in next gen (#…

ff4d84b

…9880)" (#9885) (#9886) close #9879 Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: lhy1024 <admin@liudos.us>

lhy1024 added the nextgen Indicates that the Issue or PR belongs to the nextgen kernel architecture. label Oct 30, 2025

Conversation

lhy1024 commented Oct 28, 2025

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

Uh oh!

bufferflies Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Oct 28, 2025

Uh oh!

ti-chi-bot bot commented Oct 28, 2025

[LGTM Timeline notifier]

Uh oh!

lhy1024 commented Oct 28, 2025

Uh oh!

lhy1024 commented Oct 28, 2025

Uh oh!

lhy1024 commented Oct 28, 2025

Uh oh!

lhy1024 commented Oct 28, 2025

Uh oh!

codecov bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rleungx commented Oct 28, 2025

Uh oh!

lhy1024 commented Oct 28, 2025

Uh oh!

lhy1024 commented Oct 28, 2025

Uh oh!

lhy1024 commented Oct 28, 2025

Uh oh!

lhy1024 commented Oct 28, 2025

Uh oh!

lhy1024 commented Oct 28, 2025

Uh oh!

lhy1024 commented Oct 28, 2025

Uh oh!

lhy1024 commented Oct 28, 2025

Uh oh!

lhy1024 commented Oct 28, 2025

Uh oh!

Uh oh!

lhy1024 commented Oct 28, 2025

Uh oh!

ti-chi-bot commented Oct 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Oct 28, 2025 •

edited

Loading