Skip to content

Expose the setting of the maximum size of prefill-for-recycle to users#301

Merged
BusyJay merged 3 commits intotikv:masterfrom
LykxSassinator:unleash_prefill_limit
Mar 30, 2023
Merged

Expose the setting of the maximum size of prefill-for-recycle to users#301
BusyJay merged 3 commits intotikv:masterfrom
LykxSassinator:unleash_prefill_limit

Conversation

@LykxSassinator
Copy link
Copy Markdown
Contributor

Description

This pr is used to unleash the limitation of prefill-for-recycle, used to adaptive to the requirement of large threshold.

Related issue: tikv/tikv#14468.

Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3c442af) 97.89% compared to head (7688209) 97.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #301   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files          31       31           
  Lines       12188    12228   +40     
=======================================
+ Hits        11931    11971   +40     
  Misses        257      257           
Impacted Files Coverage Δ
src/config.rs 98.08% <100.00%> (+0.45%) ⬆️
src/file_pipe_log/pipe_builder.rs 95.97% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BusyJay
Copy link
Copy Markdown
Member

BusyJay commented Mar 30, 2023

Why prefill writes data instead of using falloc?

@LykxSassinator
Copy link
Copy Markdown
Contributor Author

Why prefill writes data instead of using falloc?

Directly using falloc just creates sparse files. And it will introduce extra initializing on blocks when reusing them by recycling logs, making the first rewrite progress costs more time on fsync.

Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Copy link
Copy Markdown
Contributor Author

@BusyJay PTAL, thx.

@LykxSassinator LykxSassinator changed the title Unleash the limitation of the maximum size of prefill-for-recycle. Expose the setting of the maximum size of prefill-for-recycle to users Mar 30, 2023
Copy link
Copy Markdown
Member

@BusyJay BusyJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>
@BusyJay BusyJay merged commit 39f4db4 into tikv:master Mar 30, 2023
@LykxSassinator LykxSassinator deleted the unleash_prefill_limit branch March 30, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants