Skip to content

Use simple match in test (to avoid warning about expensive regex)#2485

Merged
shadowspawn merged 3 commits into
tj:release/15.xfrom
shadowspawn:avoid-regex-warning-in-test
Mar 7, 2026
Merged

Use simple match in test (to avoid warning about expensive regex)#2485
shadowspawn merged 3 commits into
tj:release/15.xfrom
shadowspawn:avoid-regex-warning-in-test

Conversation

@shadowspawn

@shadowspawn shadowspawn commented Feb 21, 2026

Copy link
Copy Markdown
Collaborator

Problem

CodeQL reports:

Polynomial regular expression used on uncontrolled data

for regex assert(!/\W-h\W.*display help/.test(helpInformation));

Solution

This isn't a vulnerability since only used within test with controlled data, but want to fix warning/error anyway.

Just replace regex with some simple string matches.

@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Mar 7, 2026
@shadowspawn shadowspawn merged commit 987f289 into tj:release/15.x Mar 7, 2026
9 checks passed
@shadowspawn shadowspawn deleted the avoid-regex-warning-in-test branch March 7, 2026 02:37
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label May 29, 2026
@shadowspawn

Copy link
Copy Markdown
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants