Skip to content

Fix a case when the alias is not a proper sub path#177

Merged
tleunen merged 2 commits intomasterfrom
fix-prefix-alias
May 16, 2017
Merged

Fix a case when the alias is not a proper sub path#177
tleunen merged 2 commits intomasterfrom
fix-prefix-alias

Conversation

@fatfisz
Copy link
Copy Markdown
Contributor

@fatfisz fatfisz commented May 15, 2017

I noticed it by an accident, but it seems fairly serious. There were no tests for this.

For example if an alias exists for components, then components_dummy should not be aliased, only components or components/*.

@fatfisz fatfisz requested a review from tleunen May 15, 2017 22:13
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2017

Codecov Report

Merging #177 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
src/normalizeOptions.js 100% <100%> (ø) ⬆️

Copy link
Copy Markdown
Owner

@tleunen tleunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call.

@tleunen tleunen merged commit dcd5dca into master May 16, 2017
@tleunen tleunen deleted the fix-prefix-alias branch May 16, 2017 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants