fix(cargo): Bump dependencies so that Tokio compiles with minimal versions#258
Merged
carllerche merged 1 commit intotokio-rs:masterfrom Mar 27, 2018
Merged
Conversation
Member
|
Thanks for the report! A minimal version installer would definitely be helpful to catch these issues. |
Contributor
Author
|
Yep, we are almost there at rust-lang/cargo#5200 :-) |
Member
|
Would you be able to merge master? This should hopefully fix CI. |
49b561c to
c5f213f
Compare
Contributor
Author
|
Done, rebased this on master. Ideally we should add I need to find out when cargo nightly is pushed downstream to Rust nightly. |
Member
|
Thanks. It should be soon. Let's see if it lands tomorrow. |
Member
|
Did this land? |
Member
|
I merged, but I would love to get this added to CI. |
|
ping! it is on nightly (for a while now) feel free to add it to CI! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on minimal version installer for cargo, turns out some dependencies are out of date:
Updating log to 0.4 as in the other tokio crates here and updating bytes to fix the type errors.