Add priority queue interface with a binary heap–based implementation by simonvonhackewitz · Pull Request #6873 · tokiwa-software/fuzion

simonvonhackewitz · 2026-04-07T13:33:43Z

No description provided.

michaellilltokiwa

Lots of small(er) comments from me, sorry. Overall structure is pretty much what I would expect. We have a mutable queue definition with enqueue/dequeue functionality. Of to a good start!

michaellilltokiwa · 2026-04-08T08:21:52Z

+
+  # unordered elements to construct the queue from
+  #
+  initial_elements option (Sequence T)) ref : container.Mutable_Priority_Queue T is


Since this constructor is not public anyway, I would probably prefer all initialization to be done outside of the constructor. So it would have elements as an arg instead of initial_elements.
This way the constructor does not not contain any code which may make error handling more easy.

michaellilltokiwa

I think the histogram is a good start.
What I'm missing is - the probably most important metric - is WCET (worst case execution time). An also some heuristic how the determine if this is within a certain range.

fridis

Good work!

I have a number of comments, but mostly some more documentation and some code that I would like to see at other places, so nothing major to commplain.

I have not checked the tests and benchmarks yet, but that should not be blocking.

Some comments can be addressed later, so do not consider them as blocking your documentation etc.

as well as peek and contains

… in precondition

…ices

…ture

fridis

The test is already good in the sense that it covers diifferent and important cases.

I made a number of suggestions how this test could be more systematic. Please just pick and chose comments that you would like to include in your thesis and ignore what is too much for now.

Some design decisions (like using a compare function instead of property.orderable, adding min/max variants, etc.) result in an explosion of configurations and make it harder to test this. At a later point in time, I would like you to revisit these decisions.

* use `as_string_tree_vertical` more often * don't mix output with feature `expect` * have `expect` print nothing in case of success

michaellilltokiwa

Good work!

maxteufel reviewed Apr 8, 2026

View reviewed changes

Comment thread modules/base/src/container/Binary_Heap_Queue.fz Outdated

Comment thread modules/base/src/container/Binary_Heap_Queue.fz Outdated

michaellilltokiwa reviewed Apr 8, 2026

View reviewed changes

simonvonhackewitz force-pushed the priority_queue branch from 236188b to 183dd6b Compare April 14, 2026 15:33

simonvonhackewitz added enhancement New feature or request base changes related to base module labels Apr 15, 2026

simonvonhackewitz force-pushed the priority_queue branch from 8189688 to 8ddb796 Compare April 15, 2026 16:06

simonvonhackewitz changed the title ~~WIP: add priority queue using a binary heap internally~~ add priority queue using a binary heap internally Apr 16, 2026

michaellilltokiwa reviewed Apr 16, 2026

View reviewed changes

simonvonhackewitz force-pushed the priority_queue branch from 31c987c to 6e3d5be Compare April 16, 2026 13:46

fridis reviewed Apr 20, 2026

View reviewed changes

simonvonhackewitz added 20 commits April 21, 2026 13:31

Add type / base structure, still missing most inner features

4f85803

add abstract features

3fddc51

implement type.new_comp

0a1c370

implement enqueue and up_heap, add debug output for tree

47a146d

fix tree printing for debugging

84c8977

mutate.array: implement features required for queue

8174d4d

implement dequeue and down_heap

341fff7

as well as peek and contains

avoid unnecessary type parameter in type features by using constraint…

6f074e3

… in precondition

make parent and children return options to never have invalid ind…

eb266f6

…ices

fix tree printing to work with child index options, improve code

5963720

add enqueue_dequeue

31d744d

add comments, improve code

83b2f5d

add check_heap_property for testing purpose

b943414

add enqueue_all as a convenience feature

7da070d

rename "new" to "empty", add missing comments, remove unused test fea…

11a1bb6

…ture

add efficient way to make new queue from unordered elements

9060036

add as_unordered to get Sequence of all elements

e5c7c69

add missing comments, remove some debug code

0ad3a5e

adjust to changed Fuzion base API

5e1db91

add comments for outer queue features, fix name in comment

8485380

simonvonhackewitz added 4 commits April 22, 2026 12:10

add benchmark to check time complexity of make heap

449ab68

rerecord test where error output changed due to changes in mutate.array

d4664d2

Add a test for alternating enqueue and dequeue operations

3289acf

add benchmark for inserting only elements with equal priority

ba75b07

fridis reviewed Apr 27, 2026

View reviewed changes

maxteufel reviewed Apr 29, 2026

View reviewed changes

Comment thread modules/base/src/container/Mutable_Priority_Queue.fz Outdated

Comment thread modules/base/src/container/Mutable_Priority_Queue.fz Outdated

Comment thread modules/base/src/container/Binary_Heap_Queue.fz Outdated

Comment thread modules/base/src/container/Binary_Heap_Queue.fz Outdated

fridis reviewed Apr 29, 2026

View reviewed changes

Comment thread modules/base/src/container/Binary_Heap_Queue.fz

simonvonhackewitz mentioned this pull request Apr 30, 2026

Use less_than_or_equal or lteq instead of less_or_equal #7023

Open

rename less_or_equal to less_than_or_equal

78a47b3

This was referenced Apr 30, 2026

Only template features should be ref #7024

Open

Consider adding a flexible growing/shrinking mutable array and use it in Binary_Heap_Queue #7027

Open

Re-evaluate the API for creating a priority queue #7028

Open

simonvonhackewitz added 9 commits April 30, 2026 12:29

remove unnecessary usage of .as_i64

3587cfe

fix comments and remove debug code

dfa2d7a

add or specify time complexity in comments

246d1c5

make internal feature check_heap_property private

a4385af

add comments to priority queue tests or improve existing ones

d83b5b2

fix as_string_tree_vertical for tree size of two

1142e55

improve priority queue test

3cdb02c

* use `as_string_tree_vertical` more often * don't mix output with feature `expect` * have `expect` print nothing in case of success

add comments to benchmarks

9777de5

extend same priority benchmark to test multiple queue sizes

a818c20

simonvonhackewitz marked this pull request as ready for review April 30, 2026 13:37

simonvonhackewitz changed the title ~~add priority queue using a binary heap internally~~ Add a priority queue interface and an implementation based on a binary heap Apr 30, 2026

Merge branch 'main' into priority_queue

fb6bd6c

simonvonhackewitz changed the title ~~Add a priority queue interface and an implementation based on a binary heap~~ Add priority queue interface with a binary heap–based implementation Apr 30, 2026

adjust usage of random to changes in Fuzion base API

30779ec

simonvonhackewitz force-pushed the priority_queue branch from 8e07adf to 30779ec Compare April 30, 2026 14:23

michaellilltokiwa approved these changes Apr 30, 2026

View reviewed changes

simonvonhackewitz merged commit 0e5dbf3 into tokiwa-software:main Apr 30, 2026
5 checks passed

simonvonhackewitz deleted the priority_queue branch April 30, 2026 19:26

Conversation

simonvonhackewitz commented Apr 7, 2026

Uh oh!

Uh oh!

Uh oh!

michaellilltokiwa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michaellilltokiwa Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michaellilltokiwa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fridis left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fridis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michaellilltokiwa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fridis left a comment •

edited

Loading