Skip to content

fix soundness issue in constraintAssignableFrom#7026

Merged
michaellilltokiwa merged 4 commits intotokiwa-software:mainfrom
michaellilltokiwa:fix_soundness_issue
Apr 30, 2026
Merged

fix soundness issue in constraintAssignableFrom#7026
michaellilltokiwa merged 4 commits intotokiwa-software:mainfrom
michaellilltokiwa:fix_soundness_issue

Conversation

@michaellilltokiwa
Copy link
Copy Markdown
Member

@michaellilltokiwa michaellilltokiwa commented Apr 30, 2026

This passed the constraint assignability check but must not:

  t is
    e is

  v(E type : t.e) =>
    ...

  t2 : t is
  v t2.e

fixes #7025

@michaellilltokiwa
fix soundness issue in constraintAssignableFrom
460381d 
This passed the constraint assignability check but must not:
```
  t is
    e is

  v(E type : t.e) =>
    ...

  t2 : t is
  v t2.e
```

fixes tokiwa-software#7025
@michaellilltokiwa michaellilltokiwa added bug Something isn't working front end related to the front end until .fum file is created: call and type resolution, type checking, etc. labels Apr 30, 2026
@michaellilltokiwa michaellilltokiwa requested a review from a team April 30, 2026 09:49
@michaellilltokiwa michaellilltokiwa merged commit 32be061 into tokiwa-software:main Apr 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxteufel maxteufel maxteufel approved these changes

Assignees

No one assigned

Labels

bug Something isn't working front end related to the front end until .fum file is created: call and type resolution, type checking, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

soundness issue, constraint accepted even though it must not

2 participants

@michaellilltokiwa @maxteufel
⚡