Add optional creation of Bitbucket tasks for violation comments.#5
Add optional creation of Bitbucket tasks for violation comments.#5tomasbjerre merged 1 commit intotomasbjerre:masterfrom Syquel:feature/violation-comments-tasks
Conversation
| final BitbucketServerComment bitbucketComment = | ||
| client.pullRequestComment(file.getFilename(), line, comment); | ||
|
|
||
| if (violationCommentsToBitbucketApi.getCreateSingleFileCommentsTasks()) { |
There was a problem hiding this comment.
You are changing client.pullRequestComment to return the comment and not actually create the comment.
If this is false then there will be no comment created at all right? Commenting single files, without creating a task, no longer works with this change?
There was a problem hiding this comment.
client.pullRequestComment still creates the comment in BitBucket via REST-call. The only change in that method is, that it does not discard the response of the Bitbucket server anymore (the created comment including ID), but returns it.
This is necessary, because the comment ID is required to create a task on it.
There was a problem hiding this comment.
You are right! Merging it now.
|
I'm releasing the Jenkins plugin now, version 1.74! |
|
Thanks for the quick release! I already integrated this option into the violation-comments-to-stash plugin, but unfortunately it's on my laptop at work. |
|
Ok. I added an option for it and released it. |
|
Even better, thanks :) |
2 participants
This feature optionally adds a task in Bitbucket to every violation comment, which is created on the pull request.
In combination with the Bitbucket merge check "No incomplete tasks" merges of pull requests are blocked as long as the violations are not resolved.