Skip to content

chore(pinecone): Re-enable pinecone test#252

Merged
nirga merged 2 commits intotraceloop:mainfrom
detunjiSamuel:Re-enable-Pinecone-tests
May 8, 2024
Merged

chore(pinecone): Re-enable pinecone test#252
nirga merged 2 commits intotraceloop:mainfrom
detunjiSamuel:Re-enable-Pinecone-tests

Conversation

@detunjiSamuel
Copy link
Copy Markdown
Contributor

@detunjiSamuel detunjiSamuel commented May 8, 2024

Fixes #57

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 8, 2024

CLA assistant check
All committers have signed the CLA.

@gitguardian
Copy link
Copy Markdown

gitguardian bot commented May 8, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@detunjiSamuel detunjiSamuel force-pushed the Re-enable-Pinecone-tests branch from eface1f to 78cd139 Compare May 8, 2024 19:48
@nirga nirga changed the title fix(test) : Re-enable pinecone test #57 fix(test) : Re-enable pinecone test May 8, 2024
@nirga nirga changed the title fix(test) : Re-enable pinecone test chore(pinecone): Re-enable pinecone test May 8, 2024
@nirga
Copy link
Copy Markdown
Member

nirga commented May 8, 2024

@detunjiSamuel looks good! Can you just fix the lint issues?

@nirga nirga merged commit 0e5c3aa into traceloop:main May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-enable Pinecone tests

3 participants