Skip to content

fix(manual-tracing): add missing llm.request.type attribute #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
galkleinman merged 3 commits into from
May 20, 2024
Merged

fix(manual-tracing): add missing llm.request.type attribute #269

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8672d26
fix(manual-tracing): add missing llm.request.type attribute
galkleinman May 20, 2024
a574163
return deleted comma
galkleinman May 20, 2024
ba439af
adjust test as well
galkleinman May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/traceloop-sdk/src/lib/tracing/manual.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export class LLMSpan {
}[];
}) {
this.span.setAttributes({
[SpanAttributes.LLM_REQUEST_MODEL]: model,
[SpanAttributes.LLM_REQUEST_MODEL]: model
});

messages.forEach((message, index) => {
Expand Down Expand Up @@ -163,6 +163,7 @@ export function withLLMCall<
F extends ({ span }: { span: LLMSpan }) => ReturnType<F>,
>({ vendor, type }: LLMCallConfig, fn: F, thisArg?: ThisParameterType<F>) {
const span = getTracer().startSpan(`${vendor}.${type}`, {}, context.active());
span.setAttribute(SpanAttributes.LLM_REQUEST_TYPE, type);
trace.setSpan(context.active(), span);

const res = fn.apply(thisArg, [{ span: new LLMSpan(span) }]);
Expand Down
⚡