Skip to content

feat: Qdrant instrumentation#278

Merged
nirga merged 24 commits intotraceloop:mainfrom
Anush008:main
Jun 23, 2024
Merged

feat: Qdrant instrumentation#278
nirga merged 24 commits intotraceloop:mainfrom
Anush008:main

Conversation

@Anush008
Copy link
Copy Markdown

Description

This PR adds support for instrumenting @qdrant/js-client-rest.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 23, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this @Anush008! Left a couple of comments

Comment thread packages/instrumentation-qdrant/tests/instrumentation.test.ts Outdated
Comment thread packages/instrumentation-qdrant/src/instrumentation.ts
Comment thread packages/instrumentation-qdrant/src/instrumentation.ts Outdated
Comment thread packages/instrumentation-qdrant/tests/instrumentation.test.ts
Comment thread packages/instrumentation-qdrant/tests/instrumentation.test.ts Outdated
@Anush008 Anush008 marked this pull request as draft May 23, 2024 14:03
@nirga
Copy link
Copy Markdown
Member

nirga commented Jun 6, 2024

@Anush008 I've run the test locally, and the problem was that you weren't awaiting the call to upsert. I've added await and it looks like I'm getting a Not Found error:

 Error: Not Found
      at Object.fun [as upsertPoints] (/Users/nirga/vecinity/openllmetry-js/node_modules/@qdrant/openapi-typescript-fetch/dist/cjs/fetcher.js:172:23)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at QdrantClient.upsert (/Users/nirga/vecinity/openllmetry-js/node_modules/@qdrant/js-client-rest/dist/cjs/qdrant-client.js:537:26)

Updated the PR with what I ran

@Anush008
Copy link
Copy Markdown
Author

Anush008 commented Jun 6, 2024

Thanks a lot @nirga. I'll update from here.

@Anush008 Anush008 marked this pull request as ready for review June 15, 2024 09:01
Copy link
Copy Markdown
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anush008 thanks so much! Note that build is failing (looks like you're missing a dependency?). Left a small comment as well.

Comment thread packages/instrumentation-qdrant/src/instrumentation.ts Outdated
Copy link
Copy Markdown
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Anush008! This looks great overall! Can you fix the lint issues?

Copy link
Copy Markdown
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this @Anush008!

@nirga nirga merged commit 3b8224f into traceloop:main Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants