fix(tracing): otel log level setup only for non-standalone processor#600
Merged
galkleinman merged 1 commit intomainfrom Apr 29, 2025
Merged
fix(tracing): otel log level setup only for non-standalone processor#600galkleinman merged 1 commit intomainfrom
galkleinman merged 1 commit intomainfrom
Conversation
OzBenSimhonTraceloop
approved these changes
Apr 29, 2025
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 28e4165 in 1 minute and 35 seconds. Click for details.
- Reviewed
32lines of code in1files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/traceloop-sdk/src/lib/configuration/index.ts:82
- Draft comment:
Log level setup is now inside the tracingEnabled block. Ensure this is intentional, as logger configuration won’t occur if tracing is disabled. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. packages/traceloop-sdk/src/lib/configuration/index.ts:72
- Draft comment:
Removed diag.setLogger call from outside the tracing block. Ensure that it’s intended to skip OTEL logging when tracing is disabled. - Reason this comment was not posted:
Comment looked like it was already resolved.
3. packages/traceloop-sdk/src/lib/configuration/index.ts:82
- Draft comment:
Diag logger is now initialized inside the tracingEnabled condition. Confirm that OTEL logging should only be set when tracing is enabled and update docs if needed. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_Md0HWP1Mynu7FBZC
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Moves OpenTelemetry log level setup in
initialize()to occur only when tracing is enabled, preventing setup for standalone processors.ifblock checkingoptions.tracingEnabledininitialize()inindex.ts.This description was created by
for 28e4165. You can customize this summary. It will automatically update as commits are pushed.