fix(sdk): add vercel AI SDK to span-processor whitelist#607
Merged
Conversation
galkleinman
approved these changes
Jun 27, 2025
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 81a5ab0 in 1 minute and 13 seconds. Click for details.
- Reviewed
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/traceloop-sdk/src/lib/tracing/span-processor.ts:111
- Draft comment:
Added 'ai' to the whitelist. Ensure this value exactly matches the instrumentation library name from the Vercel AI SDK and consider adding an inline comment to clarify its purpose. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% While the comment correctly identifies that "ai" refers to Vercel AI SDK, suggesting an inline comment is more of a style preference than a critical code issue. The code already has clear context about Vercel AI in the onSpanEnd function. The suggestion doesn't point out any actual problems with the code's functionality. The comment might help future maintainers understand the codebase better. The "ai" string is quite terse compared to other fully-qualified library names in the list. However, per the rules, we should not make purely informative comments or suggestions that don't require clear code changes. The code works correctly as is, and the meaning of "ai" is clear from the surrounding context. The comment should be deleted as it's purely informative and doesn't highlight any actual issues that need to be fixed.
Workflow ID: wflow_rezyrNnfozaG9TLv
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 215cba5 in 30 seconds. Click for details.
- Reviewed
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/traceloop-sdk/src/lib/tracing/span-processor.ts:111
- Draft comment:
Ensure that using "ai" as the identifier is intentional. It's very generic and might conflict with other libraries. Consider documenting or renaming it (e.g. to "vercel-ai") for clarity. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_tBhB1C0aXx71eRDi
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Adds "ai" to
traceloopInstrumentationLibrariesinspan-processor.tsto process Vercel AI SDK spans.traceloopInstrumentationLibrariesinspan-processor.ts, allowing Vercel AI SDK spans to be processed.This description was created by
for 215cba5. You can customize this summary. It will automatically update as commits are pushed.