Skip to content

fix(sdk): add vercel AI SDK to span-processor whitelist#607

Merged
nirga merged 1 commit intomainfrom
vercel-ai-1
Jun 27, 2025
Merged

fix(sdk): add vercel AI SDK to span-processor whitelist#607
nirga merged 1 commit intomainfrom
vercel-ai-1

Conversation

@nirga
Copy link
Copy Markdown
Member

@nirga nirga commented Jun 27, 2025

Important

Adds "ai" to traceloopInstrumentationLibraries in span-processor.ts to process Vercel AI SDK spans.

  • Behavior:
    • Adds "ai" to traceloopInstrumentationLibraries in span-processor.ts, allowing Vercel AI SDK spans to be processed.

This description was created by Ellipsis for 215cba5. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Copy Markdown
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 81a5ab0 in 1 minute and 13 seconds. Click for details.
  • Reviewed 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/traceloop-sdk/src/lib/tracing/span-processor.ts:111
  • Draft comment:
    Added 'ai' to the whitelist. Ensure this value exactly matches the instrumentation library name from the Vercel AI SDK and consider adding an inline comment to clarify its purpose.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% While the comment correctly identifies that "ai" refers to Vercel AI SDK, suggesting an inline comment is more of a style preference than a critical code issue. The code already has clear context about Vercel AI in the onSpanEnd function. The suggestion doesn't point out any actual problems with the code's functionality. The comment might help future maintainers understand the codebase better. The "ai" string is quite terse compared to other fully-qualified library names in the list. However, per the rules, we should not make purely informative comments or suggestions that don't require clear code changes. The code works correctly as is, and the meaning of "ai" is clear from the surrounding context. The comment should be deleted as it's purely informative and doesn't highlight any actual issues that need to be fixed.

Workflow ID: wflow_rezyrNnfozaG9TLv

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Copy Markdown
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 215cba5 in 30 seconds. Click for details.
  • Reviewed 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/traceloop-sdk/src/lib/tracing/span-processor.ts:111
  • Draft comment:
    Ensure that using "ai" as the identifier is intentional. It's very generic and might conflict with other libraries. Consider documenting or renaming it (e.g. to "vercel-ai") for clarity.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_tBhB1C0aXx71eRDi

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@nirga nirga merged commit 667ba2d into main Jun 27, 2025
5 checks passed
@nirga nirga deleted the vercel-ai-1 branch June 27, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants