fix: avoid duplicate exception recording and drop str(e) from status

For start_as_current_span blocks (bedrock invoke/converse, sagemaker
endpoint invoke), add record_exception=False, set_status_on_exception=False
so the manual try/except is the sole exception handler without duplication.

Drop str(e) from all Status(StatusCode.ERROR) calls to prevent sensitive
request data from leaking into span status descriptions.

Addresses coderabbitai review feedback on #4005

Author: Koushik-Salammagari

packages/opentelemetry-instrumentation-bedrock/opentelemetry/instrumentation/bedrock/__init__.py

@@ -219,13 +219,17 @@ def with_instrumentation(*args, **kwargs):
             GenAIAttributes.GEN_AI_REQUEST_MODEL: _model,
         }
         with tracer.start_as_current_span(
-            _span_name(operation_name, _model), kind=SpanKind.CLIENT, attributes=span_attributes
+            _span_name(operation_name, _model),
+            kind=SpanKind.CLIENT,
+            attributes=span_attributes,
+            record_exception=False,
+            set_status_on_exception=False,
         ) as span:
             try:
                 response = fn(*args, **kwargs)
             except Exception as e:
                 span.record_exception(e)
-                span.set_status(Status(StatusCode.ERROR, str(e)))
+                span.set_status(Status(StatusCode.ERROR))
                 raise
             _handle_call(span, kwargs, response, metric_params, event_logger)
             return response
@@ -258,7 +262,7 @@ def with_instrumentation(*args, **kwargs):
             response = fn(*args, **kwargs)
         except Exception as e:
             span.record_exception(e)
-            span.set_status(Status(StatusCode.ERROR, str(e)))
+            span.set_status(Status(StatusCode.ERROR))
             span.end()
             raise
         _handle_stream_call(span, kwargs, response, metric_params, event_logger)
@@ -287,12 +291,14 @@ def with_instrumentation(*args, **kwargs):
             _span_name(GenAiOperationNameValues.CHAT.value, _model),
             kind=SpanKind.CLIENT,
             attributes=span_attributes,
+            record_exception=False,
+            set_status_on_exception=False,
         ) as span:
             try:
                 response = fn(*args, **kwargs)
             except Exception as e:
                 span.record_exception(e)
-                span.set_status(Status(StatusCode.ERROR, str(e)))
+                span.set_status(Status(StatusCode.ERROR))
                 raise
             _handle_converse(span, kwargs, response, metric_params, event_logger)
 
@@ -322,7 +328,7 @@ def with_instrumentation(*args, **kwargs):
             response = fn(*args, **kwargs)
         except Exception as e:
             span.record_exception(e)
-            span.set_status(Status(StatusCode.ERROR, str(e)))
+            span.set_status(Status(StatusCode.ERROR))
             span.end()
             raise
         if span.is_recording():

packages/opentelemetry-instrumentation-ollama/opentelemetry/instrumentation/ollama/__init__.py

@@ -313,7 +313,7 @@ def _wrap(
         response = wrapped(*args, **kwargs)
     except Exception as e:
         span.record_exception(e)
-        span.set_status(Status(StatusCode.ERROR, str(e)))
+        span.set_status(Status(StatusCode.ERROR))
         span.end()
         raise
     end_time = time.perf_counter()
@@ -394,7 +394,7 @@ async def _awrap(
         response = await wrapped(*args, **kwargs)
     except Exception as e:
         span.record_exception(e)
-        span.set_status(Status(StatusCode.ERROR, str(e)))
+        span.set_status(Status(StatusCode.ERROR))
         span.end()
         raise
     end_time = time.perf_counter()

packages/opentelemetry-instrumentation-replicate/opentelemetry/instrumentation/replicate/__init__.py

@@ -137,7 +137,7 @@ def _wrap(
         response = wrapped(*args, **kwargs)
     except Exception as e:
         span.record_exception(e)
-        span.set_status(Status(StatusCode.ERROR, str(e)))
+        span.set_status(Status(StatusCode.ERROR))
         span.end()
         raise
 

packages/opentelemetry-instrumentation-sagemaker/opentelemetry/instrumentation/sagemaker/__init__.py

@@ -95,13 +95,16 @@ def with_instrumentation(*args, **kwargs):
             return fn(*args, **kwargs)
 
         with tracer.start_as_current_span(
-            "sagemaker.completion", kind=SpanKind.CLIENT
+            "sagemaker.completion",
+            kind=SpanKind.CLIENT,
+            record_exception=False,
+            set_status_on_exception=False,
         ) as span:
             try:
                 response = fn(*args, **kwargs)
             except Exception as e:
                 span.record_exception(e)
-                span.set_status(Status(StatusCode.ERROR, str(e)))
+                span.set_status(Status(StatusCode.ERROR))
                 raise
             _handle_call(span, event_logger, kwargs, response)
 
@@ -122,7 +125,7 @@ def with_instrumentation(*args, **kwargs):
             response = fn(*args, **kwargs)
         except Exception as e:
             span.record_exception(e)
-            span.set_status(Status(StatusCode.ERROR, str(e)))
+            span.set_status(Status(StatusCode.ERROR))
             span.end()
             raise
 

packages/opentelemetry-instrumentation-together/opentelemetry/instrumentation/together/__init__.py

@@ -126,7 +126,7 @@ def _wrap(
         response = wrapped(*args, **kwargs)
     except Exception as e:
         span.record_exception(e)
-        span.set_status(Status(StatusCode.ERROR, str(e)))
+        span.set_status(Status(StatusCode.ERROR))
         span.end()
         raise