fix(vector-db): prevent duplicate exception recording in span context managers

Add record_exception=False and set_status_on_exception=False to all
start_as_current_span calls in chromadb, pinecone, weaviate, lancedb,
and milvus wrappers to avoid double-recording exceptions that are
already captured by the explicit span.record_exception(e) calls.

Author: Koushik-Salammagari

packages/opentelemetry-instrumentation-chromadb/opentelemetry/instrumentation/chromadb/wrapper.py

@@ -38,7 +38,9 @@ def _wrap(tracer, to_wrap, wrapped, instance, args, kwargs):
         return wrapped(*args, **kwargs)
 
     name = to_wrap.get("span_name")
-    with tracer.start_as_current_span(name) as span:
+    with tracer.start_as_current_span(
+        name, record_exception=False, set_status_on_exception=False
+    ) as span:
         span.set_attribute(SpanAttributes.DB_SYSTEM, "chroma")
         span.set_attribute(SpanAttributes.DB_OPERATION, to_wrap.get("method"))
 
@@ -66,7 +68,7 @@ def _wrap(tracer, to_wrap, wrapped, instance, args, kwargs):
             return_value = wrapped(*args, **kwargs)
         except Exception as e:
             span.record_exception(e)
-            span.set_status(Status(StatusCode.ERROR, str(e)))
+            span.set_status(Status(StatusCode.ERROR))
             raise
         if to_wrap.get("method") == "query":
             _add_query_result_events(span, return_value)

packages/opentelemetry-instrumentation-lancedb/opentelemetry/instrumentation/lancedb/wrapper.py

@@ -35,7 +35,9 @@ def _wrap(tracer, to_wrap, wrapped, instance, args, kwargs):
         return wrapped(*args, **kwargs)
 
     name = to_wrap.get("span_name")
-    with tracer.start_as_current_span(name) as span:
+    with tracer.start_as_current_span(
+        name, record_exception=False, set_status_on_exception=False
+    ) as span:
         span.set_attribute(SpanAttributes.DB_SYSTEM, "lancedb")
         span.set_attribute(SpanAttributes.DB_OPERATION, to_wrap.get("method"))
 
@@ -50,7 +52,7 @@ def _wrap(tracer, to_wrap, wrapped, instance, args, kwargs):
             return_value = wrapped(*args, **kwargs)
         except Exception as e:
             span.record_exception(e)
-            span.set_status(Status(StatusCode.ERROR, str(e)))
+            span.set_status(Status(StatusCode.ERROR))
             raise
 
     return return_value

packages/opentelemetry-instrumentation-milvus/opentelemetry/instrumentation/milvus/wrapper.py

@@ -77,7 +77,9 @@ def _wrap(
 
     method = to_wrap.get("method")
     name = to_wrap.get("span_name")
-    with tracer.start_as_current_span(name) as span:
+    with tracer.start_as_current_span(
+        name, record_exception=False, set_status_on_exception=False
+    ) as span:
         span.set_attribute(SpanAttributes.DB_SYSTEM, "milvus")
         span.set_attribute(SpanAttributes.DB_OPERATION, to_wrap.get("method"))
 
@@ -114,7 +116,7 @@ def _wrap(
             )
             span.set_attribute(ERROR_TYPE, error_type)
             span.record_exception(e)
-            span.set_status(SpanStatus(StatusCode.ERROR, str(e)))
+            span.set_status(SpanStatus(StatusCode.ERROR))
             raise
 
         shared_attributes = {

packages/opentelemetry-instrumentation-pinecone/opentelemetry/instrumentation/pinecone/__init__.py

@@ -143,6 +143,8 @@ def _wrap(
         attributes={
             AISpanAttributes.VECTOR_DB_VENDOR: "Pinecone",
         },
+        record_exception=False,
+        set_status_on_exception=False,
     ) as span:
         if span.is_recording():
             _set_input_attributes(span, instance, kwargs)
@@ -158,7 +160,7 @@ def _wrap(
             response = wrapped(*args, **kwargs)
         except Exception as e:
             span.record_exception(e)
-            span.set_status(Status(StatusCode.ERROR, str(e)))
+            span.set_status(Status(StatusCode.ERROR))
             raise
         end_time = time.time()
 

packages/opentelemetry-instrumentation-weaviate/opentelemetry/instrumentation/weaviate/wrapper.py

@@ -38,7 +38,9 @@ def _wrap(tracer, to_wrap, wrapped, instance, args, kwargs):
         return wrapped(*args, **kwargs)
 
     name = to_wrap.get("span_name")
-    with tracer.start_as_current_span(name) as span:
+    with tracer.start_as_current_span(
+        name, record_exception=False, set_status_on_exception=False
+    ) as span:
         span.set_attribute(SpanAttributes.DB_SYSTEM, "weaviate")
         span.set_attribute(SpanAttributes.DB_OPERATION, to_wrap.get("method"))
 
@@ -51,7 +53,7 @@ def _wrap(tracer, to_wrap, wrapped, instance, args, kwargs):
             return_value = wrapped(*args, **kwargs)
         except Exception as e:
             span.record_exception(e)
-            span.set_status(Status(StatusCode.ERROR, str(e)))
+            span.set_status(Status(StatusCode.ERROR))
             raise
 
     return return_value