[ingress-nginx] #12955 not fixed: Preserve query parameters when using app-root annotation

[dfeinblatt]

Welcome!

• Yes, I've searched similar issues on GitHub and didn't find any.
• Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?

When using the ingress-nginx provider with the nginx.ingress.kubernetes.io/app-root annotation, query parameters for requests to the root are not preserved in the redirect. This is a re-report of the issue originally reported in #12955, as the resolution #12986 was incomplete. Specifically, the PR updated the regex to add a new capture group for the query parameters, but did not update the Replacement to include the captured query parameters.

For example, take an ingress with annotation nginx.ingress.kubernetes.io/app-root: /login

Expected behavior

• https://site.example.com/ redirects to https://site.example.com/login/
• https://site.example.com/?foo=bar redirects to https://site.example.com/login/?foo=bar

What did you see instead?

Observed behavior

• https://site.example.com/ redirects to https://site.example.com/login (as expected)
• https://site.example.com/?foo=bar redirects to https://site.example.com/login (query parameters are dropped)

What version of Traefik are you using?

3.7.3

What is your environment & configuration?

Using the kubernetesingressnginx

If applicable, please paste the log output in DEBUG level

No response

[dfeinblatt]

I will submit an PR to fix this next week.

[rtribotte]

Hi @dfeinblatt,

Thanks for the report and for proposing a PR, please make sure the PR targets the v3.6 branch.

[dfeinblatt]

Hi @dfeinblatt,

Thanks for the report and for proposing a PR, please make sure the PR targets the v3.6 branch.

@rtribotte The feature to add support for app-root nginx annotation was only first added in v3.7.0. So I believe I should be targeting v3.7 branch for this, not v3.6. I submitted the PR for v3.7, though let me know if this was incorrect. Thanks