chore: bump deps blocked by ESM by Lemonexe · Pull Request #23249 · trezor/trezor-suite

Lemonexe · 2025-11-19T21:27:22Z

Description

After bumping node to 24 in #23206, all our CJS–ESM pains have been washed away, magically solved in nodeJS nodejs/node#51977, so now everything will be 🌈 and 🦄 ❤️

Problems were mainly in these domains:

electron-main
playwright test runtime (not to be confused with the tested app, which runs in browser)
- FYI: we don't transpile or bundle our test runtime files, because playwright has a TS loader, something like tsx, so we're loading TS files, which are written in ES, but the TS loader transpiles them on the fly to execute them in nodeJS in CJS mode
  - playwright can run in ESM mode, but support is experimental and I haven't made it work.
- executing test files that import ESM only packages was not possible until node 24, now it just works 🎉
jest easily solvable by babel using this approach. This is already done a lot in mobile..
- Note that this is nothing new, we could have done this always
metro, not really solved, just hacked 😕

And so I bumped all packages that were considered blocked:

electron-store (electron-main)
@noble/curves (electron-main, playwright)
uuid (playwright)
chalk (electron-main, some scripts)

QA instructions

desktop builds here

Suite Desktop: on Win, macOS, Linux, test that these settings are correctly persisted (electron-store):

ℹ️ just FYI: electron-store is not the primary storage of userdata, that's IDB which is both for Web & Desktop. Only some specific data that are related to Desktop app behavior in relation to OS are stored in electron-store
Need to test at least some of the settings, that they are correctly persisted after app relaunch
- window size
- biometric authentication enabled/disabled
- tor enabled/disabled
- bridge choice
- theme choice

Suite Desktop, Web, Android, iOS (@noble/curves)

device authenticity check, please test production TS7 on
evolu getProofOfDelegatedIdentity how to test??

Also uuid: Not much to test, it's a tiny utility hidden beneath. Testable is only desktop/web Message system manager (correctly generates random uuid).

And some CI scripts which I have all tested:

yarn check-workspace-resolutions
yarn workspace @suite-common/icons generate-icons
yarn update-project-references
yarn generate-package @suite-common/blabla

And green CI means Playwright and Jest is OK 💚

Related issue

Resolve #22316
Resolve #14482

Notes

Actually, this nodeJS feature was even backported to 22.12, so we could have done it much sooner 🤦 But we were staying on 22.11 for the past year, and I only realized that now.. This is however highly relevant for electron-main, because electron-main environemnt is driven by electron, not by our repo. Electron ships with node 22.20 as of 39. That's why I electron store can be loaded in CJS mode, and again, it's something I could have done sooner, probably at electron 35?

Note that long-term, we might still want to bundle our Electron-main script as ESM, and run it as such. That would require abandoning webpack in electron-main, probably rollup instead. But it's not so hot now..

🔍🖥️ Suite desktop test results: View in Currents

🔍🖥️ Suite web test results: View in Currents

🔍🖥️ Suite native android test results: View in Currents

trezor-bot · 2025-11-19T21:55:49Z

✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

trezor-bot · 2025-11-19T21:55:50Z

✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

Lemonexe · 2025-11-19T22:01:25Z

+                    filePath: require.resolve(rootNodeModulesPath + '/uuid/dist/index.js'),
+                    type: 'sourceFile',
+                };
+            }


Otherwise you get

Android Bundling failed 47120ms suite-native/app/index.js (8598 modules) Unable to resolve "uuid" from "suite-common/message-system/src/messageSystemUtils.ts"

Lemonexe · 2025-11-21T08:11:35Z

    "extends": "../../tsconfig.base.json",
-    "compilerOptions": {
-        "module": "commonjs",
-        "moduleResolution": "node",


deleting this effectively means changing to module: ESNext and moduleResolution: nodenext
(inheriting from tsconfig.base.json)

I don't know for what historical reason was it necessary to specify CJS module resolution for typescript, but now it isn't, because /src si bundled and /e2e is loaded via playwright typescript loader, which resolves ESM and CJS mostly quite well.

Lemonexe · 2025-11-21T08:13:49Z

        '\\.(js|jsx|ts|tsx)$': ['babel-jest', babelConfig],
    },

-    transformIgnorePatterns: ['node_modules/?!(\\@noble)/'],


this couldn't have worked, because node_modules/\@noble does not exist,
so the ?! would never match
so the pattern would never match
so all node_modules would be ignored from babel transform = same as default.

Well, this means it was not needed 🙂

Lemonexe · 2025-11-21T08:14:52Z

    modulePathIgnorePatterns: ['node_modules', '<rootDir>/lib', '<rootDir>/libDev'],
    watchPathIgnorePatterns: ['<rootDir>/libDev', '<rootDir>/lib'],
    testPathIgnorePatterns: ['<rootDir>/libDev/', '<rootDir>/lib/'],
-    transformIgnorePatterns: ['/node_modules/'],


superfluous; this is the default. Deleting this line so it uses the default in jest.base.config.js

peter-sanderson

gigachad 🐶

honzauher · 2025-12-10T14:21:14Z

QA OK based on instructions

Info:

Suite version: desktop 25.12.1 (cdf4b94)
Browser: Trezor Suite 25.12.1
OS: Win32
Screen: 1920x1080
Device: Trezor T3W1 2.9.6 universal (revision dbb7b00ce10fb7eab33fa2021c4096c623b0b146)
Transport: BluetoothTransport, BridgeTransport 3.1.0

Lemonexe added dependencies Pull requests that update a dependency file no-project This label is used to specify that PR doesn't need to be added to a project labels Nov 19, 2025

Lemonexe force-pushed the chore/bump-uuid branch from 3eef0a0 to 0fcc2d3 Compare November 19, 2025 21:55

Lemonexe marked this pull request as ready for review November 19, 2025 22:01

Lemonexe requested review from a team, MiroslavProchazka, matejkriz, pavelmario and tomasklim as code owners November 19, 2025 22:01

Lemonexe commented Nov 19, 2025

View reviewed changes

Lemonexe marked this pull request as draft November 19, 2025 22:09

Lemonexe force-pushed the chore/bump-uuid branch 3 times, most recently from 2c2b4f1 to eb5abfb Compare November 20, 2025 21:14

Lemonexe changed the title ~~chore: bump uuid~~ chore: bump deps blocked by ESM Nov 20, 2025

Lemonexe marked this pull request as ready for review November 20, 2025 21:16

Lemonexe requested a review from karliatto as a code owner November 20, 2025 21:16

Lemonexe force-pushed the chore/bump-uuid branch from 9ff987e to 324e4c2 Compare November 21, 2025 07:57

Lemonexe commented Nov 21, 2025

View reviewed changes

Lemonexe added this to Suite Nov 21, 2025

Lemonexe removed the no-project This label is used to specify that PR doesn't need to be added to a project label Nov 21, 2025

Lemonexe moved this to 🔎 Needs review in Suite Nov 21, 2025

Lemonexe commented Nov 21, 2025

View reviewed changes

Comment thread suite-common/wallet-core/src/device/delegatedIdentityKey/getProofOfDelegatedIdentity.ts Outdated

Lemonexe added 3 commits November 21, 2025 17:17

chore: bump uuid

18c9fac

chore: bump chalk

67d0f1f

chore: bump @noble/curves

d34585a

chore(suite-desktop): bump electron-store

56ae763

Lemonexe force-pushed the chore/bump-uuid branch from 324e4c2 to 56ae763 Compare November 21, 2025 16:37

peter-sanderson reviewed Nov 21, 2025

View reviewed changes

peter-sanderson approved these changes Nov 21, 2025

View reviewed changes

Lemonexe merged commit c1b8a26 into develop Nov 21, 2025
37 checks passed

Lemonexe deleted the chore/bump-uuid branch November 21, 2025 17:15

github-project-automation Bot moved this from 🔎 Needs review to 🤝 Needs QA in Suite Nov 21, 2025

Lemonexe mentioned this pull request Nov 26, 2025

chore: bump nodeJS to 24 trezor/trezor-suite-sync#56

Merged

honzauher moved this from 🤝 Needs QA to 🧪 QA In progress in Suite Dec 8, 2025

honzauher mentioned this pull request Dec 10, 2025

Electron-main with ESM-only deps #14482

Closed

honzauher moved this from 🧪 QA In progress to ✅ Approved in Suite Dec 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: bump deps blocked by ESM#23249

chore: bump deps blocked by ESM#23249
Lemonexe merged 4 commits intodevelopfrom
chore/bump-uuid

Lemonexe commented Nov 19, 2025 •

edited

Loading

Uh oh!

trezor-bot Bot commented Nov 19, 2025 •

edited

Loading

Uh oh!

trezor-bot Bot commented Nov 19, 2025 •

edited

Loading

Uh oh!

Lemonexe Nov 19, 2025

Uh oh!

peter-sanderson Nov 20, 2025

Uh oh!

Lemonexe Nov 21, 2025

Uh oh!

Lemonexe Nov 21, 2025 •

edited

Loading

Uh oh!

Lemonexe Nov 21, 2025 •

edited

Loading

Uh oh!

Uh oh!

peter-sanderson left a comment

Uh oh!

Uh oh!

honzauher commented Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Lemonexe commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

QA instructions

Related issue

Notes

Uh oh!

trezor-bot Bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trezor-bot Bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Lemonexe Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

peter-sanderson Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Lemonexe Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Lemonexe Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lemonexe Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

peter-sanderson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

honzauher commented Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Lemonexe commented Nov 19, 2025 •

edited

Loading

trezor-bot Bot commented Nov 19, 2025 •

edited

Loading

trezor-bot Bot commented Nov 19, 2025 •

edited

Loading

Lemonexe Nov 21, 2025 •

edited

Loading

Lemonexe Nov 21, 2025 •

edited

Loading