Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new HTTP QA regression test intended to ensure Triton’s /v2/repository/index request handling remains robust (and the server stays live) when presented with extremely deeply nested JSON input.
Changes:
- Add a new Python HTTP test that posts a deeply-nested JSON payload to
/v2/repository/indexand verifies the server remains live. - Update the L0 HTTP test harness to expect one additional Python unit test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
qa/L0_http/test.sh |
Bumps expected Python test count from 13 to 14 to include the new test. |
qa/L0_http/http_test.py |
Adds test_repository_index_deeply_nested_json to exercise deep JSON parsing on repository index requests and then checks liveness. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
whoisj
previously approved these changes
Apr 17, 2026
yinggeh
requested changes
Apr 20, 2026
…parsing-causes-denial-of-service
…parsing-causes-denial-of-service
whoisj
previously approved these changes
Apr 23, 2026
…parsing-causes-denial-of-service
yinggeh
approved these changes
Apr 24, 2026
pskiran1
deleted the
spolisetty/tri-868-psirt-triton-nested-json-parsing-causes-denial-of-service
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
This PR adds a new HTTP QA regression test intended to ensure Triton’s
/v2/repository/indexrequest handling remains robust (and the server stays live) when presented with extremely deeply nested JSON input.Related PRs: triton-inference-server/common#156
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Where should the reviewer start?
Test plan:
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)