Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
output_len < input_len + 8, which allowed out-of-bounds writes for slightly undersized output buffers.Description
header_size = 5 + 8 + 4and validate capacity withif (output_len < header_size || input_len > output_len - header_size)insimple_compressto prevent overflow when writing the header and payload.simple_decompressminimum-input checks and payload offsets to use the same fixed-width header layout (5 + 8 + 4) so framing logic is consistent.src/lib/brotli.inc.cand preserve the existing framing format and behavior for correctly-sized buffers.Testing
make -j4which built the main binary and library successfully.make -C test/unitand unit binaries were built successfully; unit targets completed without errors.make -C testwhich stopped during integration due to missing external tools (xxd,file,7z) in the environment, so integration script checks could not complete here.Codex Task