Conversation
The zstd implementation had a critical buffer overflow bug when updating the window buffer. When copying data to the circular window buffer, the code did not properly handle the case where the data would wrap around the buffer boundary. For example, with a 128KB window and 65535-byte blocks, if the current position was at 100KB, a memcpy would attempt to write past the 128KB boundary, causing a heap buffer overflow. This fix properly handles circular buffer wrap-around by splitting the memcpy into two operations when necessary: - Part 1: Copy from current position to end of buffer - Part 2: Copy remaining data from start of buffer This ensures the circular buffer implementation remains within bounds and fixes the segmentation fault that occurred on Linux when compressing large files with zstd method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.