update go modules#4365
Closed
shahzadhaider1 wants to merge 1 commit into
Closed
Conversation
kashifkhan0771
approved these changes
Aug 5, 2025
kashifkhan0771
left a comment
kashifkhan0771
left a comment
Contributor
There was a problem hiding this comment.
Approved from my end. I've also requested a review from @ahrav. I'm not sure if this change will have any side effects.
Contributor
Author
|
It looks like there's already an existing PR that addresses this: #4342. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
github.com/bradleyfalzon/ghinstallation/v2to the latest version (v2.16.0).github.com/golang-jwt/jwt/v4is bumped tov4.5.2, addressing a known security vulnerability.Details:
The upgrade was necessary due to the following security advisory affecting jwt/v4
v4.5.1:🔗 https://github.com/trufflesecurity/trufflehog/security/dependabot/44
Testing:
✅ Ran tests for the GitHub source, all tests passed.
✅ Performed a manual GitHub scan, and it worked as expected.
ghinstallationnow depends on the fixed version (jwt/v4v4.5.2) as ofv2.16.0, so updating it resolves the issue transitively.Checklist:
make test-community)?make lintthis requires golangci-lint)?