Fixed syslog source panic on invalid or chunked input#4366
Merged
Conversation
camgunz
approved these changes
Aug 5, 2025
shahzadhaider1
approved these changes
Aug 5, 2025
peterfraedrich
pushed a commit
to peterfraedrich/trufflehog
that referenced
this pull request
Mar 15, 2026
…y#4366) * Fixed syslog source panic on invalid or chunked input * update test name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes: #3858
This PR fixes a panic in syslog that occurs when the input is in an invalid format or chunked at 8096 bytes. It also makes the
--formatflag required. Additionally, if TruffleHog fails to parse the input into the specified format, it ensures that the metadata is not nil, preventing potential panics. Tests have been added for various types of parsing scenarios.Checklist:
make test-community)?make lintthis requires golangci-lint)?