Skip to content

fix(detectors): skip GitLab v1 candidates with no digits to reduce false positives #4996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexanderSanin wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −0
Open

fix(detectors): skip GitLab v1 candidates with no digits to reduce false positives #4996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkg/detectors/gitlab/v1/gitlab.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,14 @@ func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (result
continue
}

// real tokens are random and always contain at least one digit;
// variable names like MAVEN_SETTINGS_PROFILE have no digits and
// are a common source of false positives when they appear within
// 40 characters of a "gitlab" keyword on a preceding line.
if !detectors.KeyIsRandom(resMatch) {
continue
}

for _, endpoint := range s.Endpoints() {
s1 := detectors.Result{
DetectorType: detector_typepb.DetectorType_Gitlab,
Expand Down
10 changes: 10 additions & 0 deletions pkg/detectors/gitlab/v1/gitlab_v1_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,16 @@ func TestGitLab_Pattern(t *testing.T) {
input: "GITLAB_TOKEN=ABc123456789dEFghIJK",
want: []string{"ABc123456789dEFghIJKhttps://gitlab.com"},
},
{
// Regression test for https://github.com/trufflesecurity/trufflehog/issues/4756
// ARG variable names that appear after GITLAB_* args in a Dockerfile must not be
// flagged as secrets because they contain no digits (KeyIsRandom check).
name: "no false positive for Dockerfile ARG variable name after GITLAB_ACCESS_TOKEN",
input: `ARG GITLAB_ACCESS_TOKEN_TYPE=Private-Token
ARG GITLAB_ACCESS_TOKEN
ARG MAVEN_SETTINGS_PROFILE=test`,
want: []string{},
},
}

for _, test := range tests {
Expand Down
⚡