[INS-473] Add wit detector to defaults.go, gate it behind feat flag and update verification logic#5008
Merged
Merged
Conversation
Corpora Test ResultsNo detector regex or keyword changes in this PR. Bench skipped. |
unsmith
approved these changes
Jun 5, 2026
mustansir14
approved these changes
Jun 8, 2026
MuneebUllahKhan222
force-pushed
the
wit-detector
branch
from
6540e8a to
2d5fc42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the Wit detector to defaults.go and gates it behind the appropriate feature flag.
Additionally, the PR updates the detector verification logic to align with the latest API behavior and validation requirements.
Corpora Test:
The detector does not appear in the list.
Checklist:
make test-community)?make lintthis requires golangci-lint)?Note
Medium Risk
Turns on a new default-scan detector (flag on in OSS) and changes live Wit.ai verification behavior, which can shift verified/unverified results and external API traffic during scans.
Overview
Registers the Wit.ai detector in the default engine list and rolls it out behind
WitDetectorEnabled, which OSS enables by default inmain.goalongside other gated detectors.defaults_testtreats Wit as feature-flag gated instead of “never wired up.”The Wit scanner itself is tightened up: deduped regex matches, verification moved to
verifyWitKeyagainstGET /apps(replacing the old/messageprobe), explicit 200 vs 401/403 handling withSetVerificationError, and response body drain on close. Integration tests now usego-cmpwith ignored result fields.Reviewed by Cursor Bugbot for commit 9fd3359. Bugbot is set up for automated code reviews on this repo. Configure here.