Skip to content

fix(overflow): Fix integer overflows in BinaryEncoding and Pactus #4592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
satoshiotomakan merged 2 commits into from
Dec 16, 2025
Merged

fix(overflow): Fix integer overflows in BinaryEncoding and Pactus #4592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51e95bf
fix(binary-coding): Avoid unsigned integer overflow
satoshiotomakan Dec 16, 2025
052b0e3
fix(pactus): Avoid unsigned integer overflow
satoshiotomakan Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion rust/chains/tw_pactus/src/types/amount.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,15 @@ pub struct Amount(pub i64);

impl Encodable for Amount {
fn encode(&self, w: &mut dyn std::io::Write) -> Result<(), Error> {
VarInt::from(self.0 as usize).encode(w)
let amount: usize = match self.0.try_into() {
Ok(amount) => amount,
Err(_) => {
return Err(Error::IoError(std::io::Error::from(
std::io::ErrorKind::InvalidInput,
)));
},
};
VarInt::from(amount).encode(w)
}

fn encoded_size(&self) -> usize {
Expand Down
4 changes: 3 additions & 1 deletion src/BinaryCoding.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,9 @@ tuple<bool, string> decodeString(const Data& in, size_t& indexInOut) {
if (!get<0>(lenTup)) { return make_tuple(false, ""); }
const auto len = get<1>(lenTup);
// read bytes into string
if (in.size() < indexInOut + len) { return make_tuple(false, ""); }
if (in.size() < indexInOut || in.size() - indexInOut < len) {
return make_tuple(false, "");
}
string result(in.data() + indexInOut, in.data() + indexInOut + len);
indexInOut += len;
return make_tuple(true, result);
Expand Down
Loading
⚡