fix(ed25519): Remove fmt::Debug implementation for PrivateKey#4662
Merged
sergei-boiko-trustwallet merged 2 commits intomasterfrom Mar 6, 2026
Merged
fix(ed25519): Remove fmt::Debug implementation for PrivateKey#4662sergei-boiko-trustwallet merged 2 commits intomasterfrom
fmt::Debug implementation for PrivateKey#4662sergei-boiko-trustwallet merged 2 commits intomasterfrom
Conversation
Copilot started reviewing on behalf of
sergei-boiko-trustwallet
February 24, 2026 15:32
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes Debug implementations/derivations from ed25519 key types to reduce the risk of accidentally logging sensitive key material, and updates ed25519 tests/imports accordingly.
Changes:
- Removed the manual
Debugimplementation fored25519::PrivateKey. - Removed
#[derive(Debug)]fromed25519::KeyPair. - Simplified tests by removing
test_debugand cleaning up unused imports / invalid-bytes assertions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| rust/tw_keypair/src/ed25519/private.rs | Removes Debug impl (and related std::fmt import) from PrivateKey. |
| rust/tw_keypair/src/ed25519/keypair.rs | Removes #[derive(Debug)] from KeyPair. |
| rust/tw_keypair/src/ed25519/mod.rs | Cleans up test imports, removes debug-focused test, and adjusts invalid-bytes assertions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Binary size comparison➡️ aarch64-apple-ios: 14.34 MB ➡️ aarch64-apple-ios-sim: 14.34 MB ➡️ aarch64-linux-android: 18.77 MB ➡️ armv7-linux-androideabi: 16.20 MB ➡️ wasm32-unknown-emscripten: 13.68 MB |
nikhil-gupta-tw
approved these changes
Feb 27, 2026
erdemaslan-tw
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily removes
Debugtrait implementations for key types in theed25519module and cleans up related tests and imports. The changes simplify the codebase by eliminating unnecessary or potentially unsafe debug output for sensitive key material, and improve test assertions for error handling.Removal of Debug Implementations and Related Code
Debugtrait implementation for thePrivateKeystruct ined25519/private.rs, reducing the risk of accidentally logging sensitive information.Debugtrait derivation from theKeyPairstruct ined25519/keypair.rs.Test Improvements and Cleanup
test_debugtest case, which previously checked debug output for key types and signatures, and updated thetest_keypair_from_invalid_bytestest to use assertion macros for error handling instead of unwrapping.Import Cleanup
KeyPairTraitfrom the test module ined25519/mod.rs.std::fmtfromed25519/private.rs.