Skip to content

fix(waves): Fix potential size_t to uint16_t incorrect cast #4681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergei-boiko-trustwallet merged 3 commits into from
Mar 6, 2026
Merged

fix(waves): Fix potential size_t to uint16_t incorrect cast #4681

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d898b95
fix(waves): Fix potential size_t to uint16_t incorrect cast
sergei-boiko-trustwallet Feb 25, 2026
4402198
fix(waves): Fix `encodeDynamicLengthBytes`
sergei-boiko-trustwallet Feb 25, 2026
780b488
fix(waves): Add missing header
sergei-boiko-trustwallet Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Waves/BinaryCoding.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,18 @@
#include <cstddef>
#include <cstdint>
#include <vector>
#include <limits>

#include "../BinaryCoding.h"

namespace TW::Waves {

/// Encodes a variable length bytes.
inline void encodeDynamicLengthBytes(std::vector<uint8_t> bytes, std::vector<uint8_t> &data) {
inline void encodeDynamicLengthBytes(const std::vector<uint8_t>& bytes, std::vector<uint8_t>& data) {
constexpr auto limit = static_cast<size_t>(std::numeric_limits<uint16_t>::max());
if (bytes.size() > limit) {
throw std::invalid_argument("Data size exceeds maximum allowed length");
}
encode16BE(static_cast<uint16_t>(bytes.size()), data);
data.insert(data.end(), bytes.begin(), bytes.end());
}
Expand Down
Loading
⚡