Add signature size verification#4712
Merged
nikhil-gupta-tw merged 1 commit intofix/public-key-verify-messagefrom Mar 26, 2026
Merged
Add signature size verification#4712nikhil-gupta-tw merged 1 commit intofix/public-key-verify-messagefrom
nikhil-gupta-tw merged 1 commit intofix/public-key-verify-messagefrom
Conversation
sergei-boiko-trustwallet
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds stricter validation for DER-encoded ECDSA signature sizes in the
PublicKey::verifyAsDERmethod, ensuring that only signatures within the valid size range are accepted. It also introduces corresponding constants and new unit tests to verify this behavior.Signature size validation improvements:
derSignatureMinSizeandderSignatureMaxSizeconstants toPublicKeyto define the valid size range for DER-encoded ECDSA signatures.PublicKey::verifyAsDERto reject signatures whose sizes are outside the valid DER range by returningfalseearly.Testing enhancements:
VerifyAsDERRejectsInvalidSignatureSizeto confirm that signatures with invalid sizes are correctly rejected byverifyAsDER.