This repository was archived by the owner on May 23, 2025. It is now read-only.
use status source for delete and redraft#1461
Merged
Conversation
charlag
approved these changes
Aug 25, 2019
Collaborator
charlag
left a comment
charlag
left a comment
There was a problem hiding this comment.
It's a nice change! It's for some time in Masto I assume. did you try out Pleroma or will it work fine without such response?
| removeItem(position) | ||
| .observeOn(AndroidSchedulers.mainThread()) | ||
| .autoDisposable(from(this, Lifecycle.Event.ON_DESTROY)) | ||
| .subscribe { (text, inReplyToId, spoilerText, visibility, sensitive, attachments, poll) -> |
Collaborator
There was a problem hiding this comment.
Need to handle errors here or?..
| .setMessage(R.string.dialog_delete_toot_warning) | ||
| .setPositiveButton(android.R.string.ok, (dialogInterface, i) -> { | ||
| timelineCases.delete(id); | ||
| timelineCases.delete(id) |
Collaborator
There was a problem hiding this comment.
also error must be handled here? Or it TimelineCases
| timelineCases.delete(id); | ||
| removeItem(position); | ||
| timelineCases.delete(id) | ||
| .observeOn(AndroidSchedulers.mainThread()) |
| /* this is not ideal since deleting last toot from an conversation | ||
| should not delete the conversation but show another toot of the conversation */ | ||
| timelineCases.delete(conversation.lastStatus.id) | ||
| .subscribeOn(Schedulers.io()) |
Collaborator
There was a problem hiding this comment.
should handle an error here
Collaborator
Author
|
Nope its not working with pleroma. Need to fallback to the old code |
Collaborator
Author
|
And of course it needs error handling, otherwise it crashes. Thx! |
charlag
approved these changes
Aug 27, 2019
noln
pushed a commit
to roma-apps/roma-android
that referenced
this pull request
Feb 16, 2020
* use status source for delete and redraft * make delete & redraft work on Pleroma again * add error handling # Conflicts: # app/src/main/java/tech/bigfig/roma/components/conversation/ConversationsViewModel.kt # app/src/main/java/tech/bigfig/roma/components/search/SearchViewModel.kt # app/src/main/java/tech/bigfig/roma/components/search/fragments/SearchStatusesFragment.kt # app/src/main/java/tech/bigfig/roma/fragment/SFragment.java # app/src/main/java/tech/bigfig/roma/network/MastodonApi.java # app/src/main/java/tech/bigfig/roma/network/TimelineCases.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref mastodon/mastodon#10669
fixes bugs with delete&redraft where mentions are lost