Update devDependencies.#26400
Conversation
|
This is the change which lead our unit test to fail: It's due to the use of Related to this PR in Babel: babel/babel#7772 EDIT: I checked to set our |
d841f0a to
34ee5b3
Compare
|
OK, so I added a couple more updates. Notes:
- -webkit-tap-highlight-color: transparent;
+ -webkit-tap-highlight-color: rgba(0, 0, 0, 0);But the minifier changes this to
|
|
Oh, and 5. I had to disable a few rules for htmllint. IMO we should drop htmllint completely unless we plan to enforce class/id styles and stuff. |
34ee5b3 to
8e40d82
Compare
|
@Johann-S: I reverted the babel updates and added karma-qunit. Tests still fail though. |
5ce8fb6 to
7f52965
Compare
|
We should delete this unit test: https://github.com/twbs/bootstrap/blob/v4-dev/js/tests/unit/tooltip.js#L525 Because it's not our job to be sure tooltips are correctly positionned, it's Popper.js's job |
|
You know better the popper stuff 👍 PS. I don't know why your modification to package-lock.json had so many unrelated changes... I just did |
d815d57 to
ccf5fb4
Compare
|
@mdo: can you check my comment above? We might need to change clean-css' settings if we need it to keep this. |
d71b862 to
9d632aa
Compare
|
@Johann-S: do you think you could look into updating babel too? |
b884d55 to
faffed2
Compare
Downgrade bundlesize until they make brotli optional since it doesn't work with node.js 10.x yet. So, babel, qunit/karma-qunit and bundle-size aren't the latest versions.
|
@Johann-S: ping ^^ |
|
I don't have time to work on Babel upgrade sorry 😟 |
|
All right, then please approve so that we merge this as is. You can tackle the Babel upgrade later, or maybe @hzoo can help us out with that. |
|
@Johann-S all good, that PR broke IE and we have a PR to fix in babel/babel#7969 |
|
@hzoo: don't we have to change our config file after >= beta45 changes? |
|
Depends on how it's used; if you mean |
|
@hzoo: yeah, I remember I read about that file in the release notes. So, does that mean we don't need to change something for our case, right? |

@Johann-S: this is after 4.1.1 is released.
We need to make sure nothing is broken due to the babel updates; they changed some things regarding the config files, so we need to read the release notes.