Skip to content

Update devDependencies.#26400

Merged
XhmikosR merged 4 commits into
v4-devfrom
v4-dev-xmr-deps
May 22, 2018
Merged

Update devDependencies.#26400
XhmikosR merged 4 commits into
v4-devfrom
v4-dev-xmr-deps

Conversation

@XhmikosR

Copy link
Copy Markdown
Member

@Johann-S: this is after 4.1.1 is released.

We need to make sure nothing is broken due to the babel updates; they changed some things regarding the config files, so we need to read the release notes.

@Johann-S

Johann-S commented Apr 27, 2018

Copy link
Copy Markdown
Member

This is the change which lead our unit test to fail:
image

It's due to the use of __proto__ which isn't implemented in IE 10 (but ok for IE 11)

Related to this PR in Babel: babel/babel#7772

EDIT:

I checked to set our browserslist to just IE 10 (ie 10) but nothing change...

@XhmikosR

Copy link
Copy Markdown
Member Author

OK, so I added a couple more updates. Notes:

  1. in reboot we have this change in the non-minified CSS
-  -webkit-tap-highlight-color: transparent;
+  -webkit-tap-highlight-color: rgba(0, 0, 0, 0);

But the minifier changes this to transparent already. @mdo not sure if this reverts the effect you want

  1. We need to fix Babel and perhaps update to the new config format?
  2. sinon is updated too
  3. karma-qunit is still the old version

@XhmikosR

XhmikosR commented Apr 30, 2018

Copy link
Copy Markdown
Member Author

Oh, and 5. I had to disable a few rules for htmllint. IMO we should drop htmllint completely unless we plan to enforce class/id styles and stuff.

@XhmikosR

XhmikosR commented May 2, 2018

Copy link
Copy Markdown
Member Author

@Johann-S: I reverted the babel updates and added karma-qunit. Tests still fail though.

@mdo: #26400 (comment)

@XhmikosR XhmikosR force-pushed the v4-dev-xmr-deps branch 3 times, most recently from 5ce8fb6 to 7f52965 Compare May 6, 2018 12:33
@Johann-S Johann-S force-pushed the v4-dev-xmr-deps branch from 3f20e68 to 26a5692 Compare May 7, 2018 14:12
@Johann-S

Johann-S commented May 7, 2018

Copy link
Copy Markdown
Member

We should delete this unit test: https://github.com/twbs/bootstrap/blob/v4-dev/js/tests/unit/tooltip.js#L525

Because it's not our job to be sure tooltips are correctly positionned, it's Popper.js's job

@XhmikosR

XhmikosR commented May 7, 2018

Copy link
Copy Markdown
Member Author

You know better the popper stuff 👍

PS. I don't know why your modification to package-lock.json had so many unrelated changes... I just did npm i using node 10.x and npm 5.6.0.

@XhmikosR XhmikosR force-pushed the v4-dev-xmr-deps branch 2 times, most recently from d815d57 to ccf5fb4 Compare May 8, 2018 08:58
@XhmikosR

XhmikosR commented May 9, 2018

Copy link
Copy Markdown
Member Author

@mdo: can you check my comment above? We might need to change clean-css' settings if we need it to keep this.

@XhmikosR XhmikosR force-pushed the v4-dev-xmr-deps branch 2 times, most recently from d71b862 to 9d632aa Compare May 13, 2018 15:54
@XhmikosR XhmikosR removed the on-hold label May 18, 2018
@XhmikosR

Copy link
Copy Markdown
Member Author

@Johann-S: do you think you could look into updating babel too?

@XhmikosR XhmikosR force-pushed the v4-dev-xmr-deps branch 2 times, most recently from b884d55 to faffed2 Compare May 21, 2018 07:07
XhmikosR and others added 2 commits May 22, 2018 15:47
Downgrade bundlesize until they make brotli optional since it doesn't work with node.js 10.x yet.

So, babel, qunit/karma-qunit and bundle-size aren't the latest versions.
@XhmikosR

Copy link
Copy Markdown
Member Author

@Johann-S: ping ^^

@Johann-S

Copy link
Copy Markdown
Member

I don't have time to work on Babel upgrade sorry 😟

@XhmikosR

Copy link
Copy Markdown
Member Author

All right, then please approve so that we merge this as is. You can tackle the Babel upgrade later, or maybe @hzoo can help us out with that.

@XhmikosR XhmikosR requested a review from Johann-S May 22, 2018 14:18
@XhmikosR XhmikosR merged commit c3da2c8 into v4-dev May 22, 2018
@XhmikosR XhmikosR deleted the v4-dev-xmr-deps branch May 22, 2018 14:26
@mdo mdo mentioned this pull request May 22, 2018
@hzoo

hzoo commented May 22, 2018

Copy link
Copy Markdown
Contributor

@Johann-S all good, that PR broke IE and we have a PR to fix in babel/babel#7969

@XhmikosR

Copy link
Copy Markdown
Member Author

@hzoo: don't we have to change our config file after >= beta45 changes?

@hzoo

hzoo commented May 22, 2018

Copy link
Copy Markdown
Contributor

Depends on how it's used; if you mean babel.config.js it's mostly for monorepo/compiling node_modules setup

@XhmikosR

Copy link
Copy Markdown
Member Author

@hzoo: yeah, I remember I read about that file in the release notes. So, does that mean we don't need to change something for our case, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants