fix tooltip on placement change#26418
Merged
Merged
Conversation
Johann-S
force-pushed
the
v4-dev-johann-fix-tooltip
branch
2 times, most recently
from
ca5ec0f to
4b46caf
Compare
Member
Author
|
@mdo should we add this fix in |
Johann-S
force-pushed
the
v4-dev-johann-fix-tooltip
branch
from
4b46caf to
3497089
Compare
Member
|
@Johann-S Is this good to go? I haven't reviewed anything here since this is a JS change. Mostly focused on CSS and docs stuff right now. |
Member
Author
|
For me it's good to go, but I'm waiting for someone to review my code 😆 /CC @XhmikosR , @bardiharborow |
Member
|
I'm not sure I get the issue myself TBH. I'm gonna approve since @Johann-S says it's OK and tests are passing. |
XhmikosR
approved these changes
Jun 25, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #25940, fixes #25519