Custom forms transition#26538
Merged
Merged
Conversation
Member
|
just to check: does this also obey the "reduced motion" thing (where transitions are disabled) https://getbootstrap.com/docs/4.1/getting-started/accessibility/#reduced-motion ? |
Member
Author
|
@patrickhlauke, |
andresgalante
approved these changes
May 21, 2018
andresgalante
left a comment
andresgalante
left a comment
Collaborator
There was a problem hiding this comment.
@MartijnCuppens cool! I like it
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is no transition applied to custom form elements. This PR adds transition to checkboxes, radios, custom range sliders, custom selects and custom file inputs.
background-colortransition is needed to transition the checkboxes and radio buttons. This is why$custom-forms-transitionis not inherited from$input-transitionDemo: https://codepen.io/MartijnCuppens/pen/OZrBYj