Skip to content

Fix xss in tooltip, collapse and scrollspy plugins#26630

Merged
Johann-S merged 4 commits into
v4-devfrom
v4-dev-jo-xss
Jun 1, 2018
Merged

Fix xss in tooltip, collapse and scrollspy plugins#26630
Johann-S merged 4 commits into
v4-devfrom
v4-dev-jo-xss

Conversation

@Johann-S

@Johann-S Johann-S commented May 30, 2018

Copy link
Copy Markdown
Member

@XhmikosR

XhmikosR commented May 30, 2018

Copy link
Copy Markdown
Member

Hmm, it seems we are having some test failures @Johann-S :/

BTW, do we have any other places like these? Would be ideal if we tackled all similar issues now and release a new patch release soon-ish.

@Johann-S

Johann-S commented May 30, 2018

Copy link
Copy Markdown
Member Author

yep I'm on it 😉 just a few minutes

It's a bit hard to identify all the possible XSS in once 😟 we should check all of our options

@XhmikosR

XhmikosR commented Jun 1, 2018

Copy link
Copy Markdown
Member

@Johann-S: let's get this merged and hopefully people will report if there are any other cases.

@Johann-S Johann-S merged commit cc61edf into v4-dev Jun 1, 2018
@Johann-S Johann-S deleted the v4-dev-jo-xss branch June 1, 2018 07:10
@mdo mdo mentioned this pull request Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants