refactor(plugins): query elements without jquery#26645
Conversation
64ca404 to
aff677b
Compare
|
I have some issues to fix for IE 😆 EDIT: |
aff677b to
39d92ab
Compare
| this._element.style[dimension] = 0 | ||
|
|
||
| if (this._triggerArray.length > 0) { | ||
| if (this._triggerArray.length) { |
There was a problem hiding this comment.
That's useless because 0 is a false value
There was a problem hiding this comment.
Obviously, but that's not my point.
There was a problem hiding this comment.
Yep but that rule isn't activated
There was a problem hiding this comment.
I never said it was :P I remember I made the length changes some time ago, so I'd say keep them even though we don't have that check.
There was a problem hiding this comment.
I prefer to remove them, it's part of the JavaScript power 💪
There was a problem hiding this comment.
I don't agree, because I'd rather be explicit when possible. It's actually one of the problems of JavaScript, not strict types etc.
There was a problem hiding this comment.
That's a well known property of JavaScript that 0 is a false value, be explicit isn't a good thing when it's hide a language particularity because other languages are different
There was a problem hiding this comment.
Sorry, I don't agree with the length removal. Even if we know that, I always prefer to be explicit.
The rest of the patch looks good, though. 👍
XhmikosR
left a comment
There was a problem hiding this comment.
Forgot to approve for the rest.
39d92ab to
160f672
Compare
Fixes: #26643
/CC @XhmikosR