Skip to content

Update gems.#26785

Merged
XhmikosR merged 1 commit into
v4-devfrom
v4-dev-xmr-gems
Jul 6, 2018
Merged

Update gems.#26785
XhmikosR merged 1 commit into
v4-devfrom
v4-dev-xmr-gems

Conversation

@XhmikosR

@XhmikosR XhmikosR commented Jul 1, 2018

Copy link
Copy Markdown
Member

No description provided.

@XhmikosR

XhmikosR commented Jul 1, 2018

Copy link
Copy Markdown
Member Author

I'm thinking, we could get rid of the redirect layout. It's only supposed to be seen when JavaScript is disabled.

@Johann-S Johann-S left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not the best in Ruby and you know our docs better than me 😄

@XhmikosR

XhmikosR commented Jul 2, 2018

Copy link
Copy Markdown
Member Author

@mdo: what do you think about removing the redirect layout?

@mdo

mdo commented Jul 3, 2018

Copy link
Copy Markdown
Member

@XhmikosR If it's unused, remove it. Otherwise, probably fine to leave.

@XhmikosR

XhmikosR commented Jul 3, 2018

Copy link
Copy Markdown
Member Author

@mdo: it's basically unused for normal visitors, i.e. with JS enabled.

@XhmikosR XhmikosR merged commit 907f9a7 into v4-dev Jul 6, 2018
@XhmikosR XhmikosR deleted the v4-dev-xmr-gems branch July 6, 2018 09:19
@mdo mdo mentioned this pull request Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants