Add missing role="button" in .navbar's .dropdown-toggle#26831
Merged
Conversation
patrickhlauke
approved these changes
Jul 9, 2018
Member
|
oops, just realised perhaps intent was not to merge due to closeness of new release...sorry if that was the case/if that creates issues now :( |
Member
Author
|
Nah, this is good I believe; it's a trivial change, don't worry. |
Closed
Contributor
|
Why does Bootstrap use |
Member
|
mainly, for ease/consistency of styling. as it's then still exposed correctly thanks to the of course, authors can use an actual but currently the baseline for the text in the links and the text in the button don't always correctly line up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26830