Update tokio-tungstenite to 0.15#1201
Closed
Erk- wants to merge 1 commit intotwilight-rs:nextfrom
Closed
Conversation
7596ff
previously approved these changes
Oct 18, 2021
vilgotf
approved these changes
Oct 18, 2021
Member
|
This is a wrap-up of discussions and research from the #dev channel on Discord:
The only real upside in bumping tokio-tungstenite to 0.15 is a faster input buffer, but the impact of that might be negligible because network latency is the bottleneck here. It is probably not worth the dependency mess we'd put ourselves in by bumping it. Rather, we should wait for 0.16 to release to allow fine-grained rustls feature flags on gateway and avoid this TLS dependency mess. This also can be done at any time, because tokio-tungstenite is not part of twilight's public API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a revive of #1028 as the parts for #1058 are yet to be published to crates.io.