Taking the square root of distances is now optional#10
Open
hochshi wants to merge 3 commits intou1234x1234:masterfrom
Open
Taking the square root of distances is now optional#10hochshi wants to merge 3 commits intou1234x1234:masterfrom
hochshi wants to merge 3 commits intou1234x1234:masterfrom
Conversation
Owner
|
Hi, Thank you for the contribution! What do you think about making it as a different metric name not as an additional My suggestion is to add a new metric or |
Author
|
Sure. I'll make the changes soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a root_dist flag that allow the distances returned from nanoflann to stay squared even when using a L2 norm.
I've also added 2 tests to verify the addition of the flag the results remain consistent with sklearn.
Also bumped the version in setup.py to 0.0.9.